Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI v2 schemas not supported #15

Open
alexzielenski opened this issue May 4, 2023 · 4 comments
Open

OpenAPI v2 schemas not supported #15

alexzielenski opened this issue May 4, 2023 · 4 comments
Assignees
@swastik959
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@alexzielenski
Copy link
Contributor

This means we can't support k8s versions lower than 1.23. It'd be nice to be able to use the older schemas. This might incur a higher burden for the overlay patches that add richer native type validations.
@apelisse
Copy link
Contributor

apelisse commented May 4, 2023

Also note that we have a piece of code somewhere that converts v2 into v3 ...

@apelisse
Copy link
Contributor

apelisse commented May 4, 2023

https://github.com/kubernetes/kube-openapi/blob/master/pkg/openapiconv/convert.go#L33-L43

@alexzielenski alexzielenski added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 5, 2023
@swastik959
Copy link
Contributor

/assign

@swastik959
Copy link
Contributor

@alexzielenski can you please tell where exactly the function should be implemented ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swastik959 swastik959

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexzielenski @apelisse @swastik959