Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support remote location for schemas #56

Open
hadar-co opened this issue Jul 2, 2023 · 7 comments
Open

Support remote location for schemas #56

hadar-co opened this issue Jul 2, 2023 · 7 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@hadar-co
Copy link

hadar-co commented Jul 2, 2023

Similar to the --local-schemas flag, it would be very useful to be able to pass an http address (such as a Github repo, for example) containing the schema.

This can done using a separate flag, or just adding this capability to the existing one.
For example:

kubectl validate ./my_crd.yaml --remote-schemas "https://raw.githubusercontent.com/myOrg/myRepo/main/folderWithSchemas/"
@alexzielenski
Copy link
Contributor

I support this idea in theory. What format do you expect schemas to be in folderWithSchemas?

@apelisse
Copy link
Contributor

Yeah, i think there's 2 things

  1. Should we be able to load directly ONE schema from http? Absolutely.
  2. Alex's question, there's no concept of folder in http, what should it do?

@hiroyaonoe
Copy link
Contributor

Alex's question, there's no concept of folder in http, what should it do?

How about following the remote-directories in kustomize?
https://github.com/kubernetes-sigs/kustomize/blob/master/examples/remoteBuild.md#remote-directories

@apelisse
Copy link
Contributor

apelisse commented Nov 6, 2023

How about following the remote-directories in kustomize?
https://github.com/kubernetes-sigs/kustomize/blob/master/examples/remoteBuild.md#remote-directories

the name is a little misleading-ish. That's specifically doing a clone and access files under that clone.

Alternatively, we could do a special loader to load from Github API.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 5, 2024
@alexzielenski
Copy link
Contributor

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants