feat: support for multiple s3 profiles #8963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up till now, we only supported a single profile. Worse, if the user had more than one *including* a profile named "default", we would always use default; otherwise we would pick the first. BREAKING CHANGE: with this PR, the aws s3 mount points are of the form `/s3/aws/default` and `/s3/aws/myOtherProfile`. Any logic that was hard-coding an expectation that `/s3/aws/mybucket` would work must now specify the profile explicitly e.g. `/s3/aws/default/mybucket` Also, neither the aws config/credentials nor the `aws` CLI support encoding the endpoint url in a config file. See aws/aws-cli#1270 Lacking this support, for now, this PR assumes that, if needed, a profile's `endpoint_url` is a config key with that name in the `config` file, e.g. ```conf [default] endpoint_url=https://my-s3-server.com ... ```
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: starpit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up till now, we only supported a single profile. Worse, if the user had more than one including a profile named "default", we would always use default; otherwise we would pick the first.
BREAKING CHANGE: with this PR, the aws s3 mount points are of the form
/s3/aws/defaultand/s3/aws/myOtherProfile. Any logic that was hard-coding an expectation that/s3/aws/mybucketwould work must now specify the profile explicitly e.g./s3/aws/default/mybucketAlso, neither the aws config/credentials nor the
awsCLI support encoding the endpoint url in a config file. See aws/aws-cli#1270Lacking this support, for now, this PR assumes that, if needed, a profile's
endpoint_urlis a config key with that name in theconfigfile, e.g.Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs