Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping to kustomize/kyaml v0.18.0 breaks kustomize/api v0.17.3 and kustomize/cmd/config v0.14.2 #5779

Open
kashifest opened this issue Oct 8, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kashifest
Copy link

What happened?

Dependabot picked up the kustomize/kyaml v0.18.0 tag and pushed a bump PR. Now after the bump the build fails with the following issues

# sigs.k8s.io/kustomize/api/internal/plugins/fnplugin
/Users/kashif/go/pkg/mod/sigs.k8s.io/kustomize/[email protected]/internal/plugins/fnplugin/fnplugin.go:80:4: unknown field EnableStarlark in struct literal of type runfn.RunFns
# sigs.k8s.io/kustomize/cmd/config/internal/commands
/Users/kashif/go/pkg/mod/sigs.k8s.io/kustomize/cmd/[email protected]/internal/commands/run-fns.go:349:3: unknown field EnableStarlark in struct literal of type runfn.RunFns
make: *** [tools/bin/kustomize] Error 1

This possibly comes from the fact that it was removed here d32eacf#diff-552ed910d0395b5defc5b44042a559e4795558e8d82cd9858199a6f1191746bf and this commit exists in kustomize/kyaml v0.18.0 tag. Do we need corresponding tags/releases for kustomize/api and /kustomize/cmd/config ?

What did you expect to happen?

build should work fine after the bump

How can we reproduce it (as minimally and precisely as possible)?

Just bump to kustomize/kyaml v0.18.0 and if you also have dependancy on kustomize/api or kustomize/cmd/config you should hit this.

Expected output

No response

Actual output

No response

Kustomize version

5.4.3

Operating system

None

@koba1t
Copy link
Member

koba1t commented Oct 17, 2024

Hi @kashifest

So sorry to made broken release.
I was fixed with create new releases with below lists. Could you try to use below versions?
'kyaml/v0.18.1', 'api/v0.18.0' and 'cmd/config/v0.15.0'

@koba1t
Copy link
Member

koba1t commented Oct 17, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 17, 2024
@kashifest
Copy link
Author

Hi @koba1t thanks for the new release tags, things are working now it seems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants