Skip to content

Commit aa2f974

Browse files
fix: resolve lint failures from dead code cleanup (#264)
Signed-off-by: Sahitya Chandra <sahityajb@gmail.com>
1 parent 7759cb9 commit aa2f974

2 files changed

Lines changed: 0 additions & 19 deletions

File tree

internal/controller/helper.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,22 +20,6 @@ import (
2020
corev1 "k8s.io/api/core/v1"
2121
)
2222

23-
24-
// stringMapEqual checks if two string maps are equal.
25-
func stringMapEqual(a, b map[string]string) bool {
26-
if len(a) != len(b) {
27-
return false
28-
}
29-
30-
for k, v := range a {
31-
if b[k] != v {
32-
return false
33-
}
34-
}
35-
36-
return true
37-
}
38-
3923
// conditionsEqual checks if two condition slices are equal.
4024
func conditionsEqual(a, b []corev1.NodeCondition) bool {
4125
if len(a) != len(b) {

internal/controller/nodereadinessrule_controller.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ func (r *RuleReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
130130
return r.reconcileDelete(ctx, rule, nodeList)
131131
}
132132

133-
134133
// Update rule cache (after cleanup)
135134
r.Controller.updateRuleCache(ctx, rule)
136135

@@ -452,7 +451,6 @@ func (r *RuleReadinessController) updateRuleCache(ctx context.Context, rule *rea
452451
"resourceVersion", ruleCopy.ResourceVersion)
453452
}
454453

455-
456454
// removeRuleFromCache removes a rule from cache.
457455
func (r *RuleReadinessController) removeRuleFromCache(ctx context.Context, ruleName string) {
458456
log := ctrl.LoggerFrom(ctx)
@@ -599,7 +597,6 @@ func (r *RuleReadinessController) cleanupTaintsForRule(ctx context.Context, rule
599597
return nil
600598
}
601599

602-
603600
func (r *RuleReconciler) ensureFinalizer(ctx context.Context, rule *readinessv1alpha1.NodeReadinessRule, finalizer string) (finalizerAdded bool, err error) {
604601
// Finalizers can only be added when the deletionTimestamp is not set.
605602
if !rule.GetDeletionTimestamp().IsZero() {

0 commit comments

Comments
 (0)