Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apparmor recorder allows extra capabilities in the profile which doesn't seem to be required #2576

Open
ccojocar opened this issue Nov 20, 2024 · 2 comments · May be fixed by #2623
Open

Apparmor recorder allows extra capabilities in the profile which doesn't seem to be required #2576

ccojocar opened this issue Nov 20, 2024 · 2 comments · May be fixed by #2623
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ccojocar
Copy link
Contributor

What happened:

The apparmor recorder apparently allows extra capabilities in the profile such as sys_admin and setpcap for nginx container when recording an apparmor profile. It seems that these capabilities are not required.

What you expected to happen:

Allow in the Apparmor profile only the minimum required capabilities.

How to reproduce it (as minimally and precisely as possible):

Record an apparmor profile for nginx container image, and check the recorded capabilities in the corresponding CR.

Anything else we need to know?:

Environment:

  • Cloud provider or hardware configuration: GKE
  • OS (e.g: cat /etc/os-release): COS
  • Kernel (e.g. uname -a):
  • Others:
@ccojocar ccojocar added the kind/bug Categorizes issue or PR as related to a bug. label Nov 20, 2024
@ccojocar
Copy link
Contributor Author

cc @mhils

@jindijamie
Copy link

Other than extra capabilities, it also includes extra paths. When I record the pod that runs sleep only. I got the following paths in recording

filesystem:
      readOnlyPaths:
      - /usr/bin/runc
      writeOnlyPaths:
      - /proc/@{pid}/attr/apparmor/exec

It looks like the recording records things happen when the container runtime starts the container as well.

@ccojocar ccojocar mentioned this issue Nov 29, 2024
Merged
@mhils mhils linked a pull request Dec 13, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
2 participants
@ccojocar @jindijamie