Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce noRetry Parameter for checkcapacity ProvisioningRequest #7496

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Introduce noRetry Parameter for checkcapacity ProvisioningRequest #7496

wants to merge 4 commits into from
+41 −1

Conversation

PBundyra
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

Introduces a new Parameter for checkcapacity ProvisioningRequests that limits retry mechanism in ClusterAutoscaler.
If the capacity can't be found then the ProvisioningRequest is marked as Failed=True instead of Provisioned=False

Which issue(s) this PR fixes:

Fixes #7495

Special notes for your reviewer:

Does this PR introduce a user-facing change?

New Parameter for checkcapacity ProvisioningRequests that limits retry mechanism

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @PBundyra!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @PBundyra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 14, 2024
@PBundyra
Copy link
Author

/assign @yaroslava-serdiuk
cc @mwielgus

@PBundyra
Copy link
Author

/assign @aleksandra-malinowska

@yaroslava-serdiuk
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2024
@yaroslava-serdiuk
Copy link
Contributor

Could you add a test case for your change? The majority of cases live in orchestrator_test file.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 18, 2024
@PBundyra
Copy link
Author

Could you add a test case for your change? The majority of cases live in orchestrator_test file.

Thanks, added

@PBundyra PBundyra closed this Nov 18, 2024
@PBundyra PBundyra reopened this Nov 18, 2024
@PBundyra PBundyra mentioned this pull request Nov 20, 2024
Open
@yaroslava-serdiuk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@aleksandra-malinowska
Copy link
Contributor

/lgtm
/approve
/hold

Couple of nits only, otherwise LGTM. Feel free to remove hold when you consider this ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@PBundyra
Copy link
Author

Thanks for reviews
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslava-serdiuk yaroslava-serdiuk yaroslava-serdiuk left review comments

@aleksandra-malinowska aleksandra-malinowska aleksandra-malinowska left review comments

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@aleksandra-malinowska aleksandra-malinowska

@yaroslava-serdiuk yaroslava-serdiuk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Parameter to checkcapacity ProvisioningRequest that disables CA's retry mechanism
4 participants
@PBundyra @k8s-ci-robot @yaroslava-serdiuk @aleksandra-malinowska