Skip to content

Commit ebf755a

Browse files
committed
address followups such as oom group, kubeadm out of scope and rename folder to reflect true name of KEP
1 parent 7bf6ad0 commit ebf755a

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

keps/sig-node/5573-cgroup-v1-unsupported/README.md renamed to keps/sig-node/5573-remove-cgroup-v1/README.md

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,13 @@ The latest release of debian "Trixie" is using [systemd 257](https://packages.de
156156
6. **Remove cgroup v1 code**: Removing the code is the next logic step once we stop testing it. This will clean up
157157
the codebase.
158158

159+
7. **Update system-validators**: system-validator should react correctly to kubelet not starting on a cgroup v1 node. See [issue](https://github.com/kubernetes/system-validators/issues/58) for more details.
160+
159161
### Non-Goals
160162

161-
NA.
163+
In this KEP, we will focus on the kubelet related work to remove cgroup v1.
164+
Projects like minikube, kubeadm, kubespray and others may need work to support this flag going to false
165+
but that is out of scope for this KEP.
162166

163167
## Proposal
164168

@@ -179,6 +183,10 @@ The primary risks involve potential disruptions for users who have not yet migra
179183
- IBM SDK Java Technology Edition Version (IBM Java): 8.0.7.15 and later
180184
- Third-party monitoring and security agents need to support cgroup v2
181185

186+
3. **oom.group**: In cgroup v2, the kernel community introduced a feature to allow the Out-of-Memory (OOM) killer to terminate an entire group of processes as an indivisible unit.
187+
- Users who need the cgroup v1 behavior can toggle `singleProcessOOMKill` to true on the kubelet config.
188+
- This will allow the kernel to kill the process that triggers OOMs without killing the rest of the processes.
189+
182190
**Mitigations**:
183191

184192
- Provide comprehensive migration documentation and guidance
@@ -224,7 +232,7 @@ klog.Warning("cgroup v1 detected. cgroup v1 support has been transitioned into m
224232
To (deprecated):
225233

226234
```golang
227-
klog.Warning("cgroup v1 detected. cgroup v1 support is deprecated and will be removed in a future release. Please migrate to cgroup v2. More information at https://git.k8s.io/enhancements/keps/sig-node/5573-cgroup-v1-unsupported")
235+
klog.Warning("cgroup v2 detected. cgroup v1 support is deprecated and will be removed in a future release. Please migrate to cgroup v2. More information at https://git.k8s.io/enhancements/keps/sig-node/5573-remove-cgroup-v1")
228236
```
229237

230238
Similar updates will be made to corresponding events.
@@ -248,7 +256,7 @@ Other lanes will be removed but we will continue supporting this lane until we f
248256
### Removal of cgroup v1
249257

250258
<UNRESOLVED @haircommander>
251-
Once all supported releases of Kubernetes have `FailCGroupV1` set to true, we can begin the removal of the cgroup v1 support.
259+
Once all supported releases of Kubernetes have `FailCgroupV1` set to true, we can begin the removal of the cgroup v1 support.
252260

253261
In this section, we should call the places where we are going to remove cgroup v1.
254262
</UNRESOLVED>
@@ -558,4 +566,4 @@ express the idea and why it was not acceptable.
558566

559567
3. **Opt-in cgroup v2**: Require explicit configuration to enable cgroup v2 instead of disabling cgroup v1 by default. This was ruled out because it doesn't provide clear signals about the deprecation path and slows adoption of the preferred technology.
560568

561-
4. **Feature gate approach**: Use a feature gate instead of a kubelet flag. This was ruled out because kubelet flags provide more direct control over the behavior and are more appropriate for this type of configuration change.
569+
4. **Feature gate approach**: Use a feature gate instead of a kubelet flag. This was ruled out because kubelet flags provide more direct control over the behavior and are more appropriate for this type of configuration change.

0 commit comments

Comments
 (0)