Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: RBAC Add view, edit and admin roles for BackendConfig #2608

Open
kassah opened this issue Jul 25, 2024 · 2 comments
Open

Feature: RBAC Add view, edit and admin roles for BackendConfig #2608

kassah opened this issue Jul 25, 2024 · 2 comments

Comments

@kassah
Copy link

kassah commented Jul 25, 2024

Right now if you issue edit role on a Namespace, you cannot add BackendConfigs within that namespace by default.

I propose that we add those ClusterRoles in:

This is what I am thinking:

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: ingress-gce-edit
  labels:
    rbac.authorization.k8s.io/aggregate-to-edit: "true"
    rbac.authorization.k8s.io/aggregate-to-admin: "true"
rules:
  - apiGroups:
      - cloud.google.com
    resources:
      - backendconfigs
    verbs:
      - create
      - delete
      - deletecollection
      - patch
      - update
---
kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: ingress-gce-view
  labels:
    rbac.authorization.k8s.io/aggregate-to-view: "true"
rules:
  - apiGroups:
      - cloud.google.com
    resources:
      - backendconfigs
    verbs:
      - get
      - list
      - watch

I know that EndpointSlices were disabled from edit permission due to possible cross-namespace namespace forwarding. I don't believe this is a problem in BackendConfigs, but someone with experience with the implimentation should confirm. See: kubernetes/kubernetes#103675

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
@kassah
Copy link
Author

kassah commented Oct 24, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants