Annotations: Allow @ in URLs.

Author: pando85

internal/ingress/annotations/parser/validators.go

@@ -44,7 +44,7 @@ var (
 	alphaNumericChars    = `\-\.\_\~a-zA-Z0-9\/:`
 	extendedAlphaNumeric = alphaNumericChars + ", "
 	regexEnabledChars    = regexp.QuoteMeta(`^$[](){}*+?|&=\`)
-	urlEnabledChars      = regexp.QuoteMeta(`,:?&=`)
+	urlEnabledChars      = regexp.QuoteMeta(`@,:?&=`)
 )
 
 // IsValidRegex checks if the tested string can be used as a regex, but without any weird character.

internal/ingress/annotations/parser/validators_test.go

@@ -60,6 +60,11 @@ func TestValidateArrayOfServerName(t *testing.T) {
 			value:   "https://oauth.example/oauth2/auth?allowed_groups=gid1,gid2",
 			wantErr: false,
 		},
+		{
+			name:    "should allow at in query params",
+			value:   "https://oauth.example/oauth2/[email protected],[email protected]",
+			wantErr: false,
+		},
 		{
 			name:    "should deny names with weird characters",
 			value:   "something.com,lolo;xpto.com,nothing.com",