Skip to content

Commit 57a852d

Browse files
committed
Fix nil skipping
1 parent d5de25f commit 57a852d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

upup/pkg/fi/topological_sort.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,13 @@ func FindTaskDependencies[T SubContext](tasks map[string]Task[T]) map[string][]s
6666

6767
var dependencyKeys []string
6868
for _, dep := range dependencies {
69-
if dep == nil {
69+
// Skip nils, including interface nils
70+
if dep == nil || reflect.ValueOf(dep).IsNil() {
7071
continue
7172
}
7273
dependencyKey, found := taskToId[dep]
7374
if !found {
74-
klog.Fatalf("dependency not found: %v", dep)
75+
klog.Fatalf("dependency for task %T:%q not found: %v", t, k, dep)
7576
}
7677
dependencyKeys = append(dependencyKeys, dependencyKey)
7778
}

0 commit comments

Comments
 (0)