From f445dfc4566ee9ab61ad8cb3305f4374529270a3 Mon Sep 17 00:00:00 2001 From: Jesse Haka Date: Tue, 30 Jan 2024 17:35:47 +0200 Subject: [PATCH] Revert "Don't set LimitNoFile for containerd systemd unit file" --- nodeup/pkg/model/containerd.go | 1 + nodeup/pkg/model/tests/containerdbuilder/complex/tasks.yaml | 1 + nodeup/pkg/model/tests/containerdbuilder/simple/tasks.yaml | 1 + 3 files changed, 3 insertions(+) diff --git a/nodeup/pkg/model/containerd.go b/nodeup/pkg/model/containerd.go index 9752bcde0378d..19e2de63afc7d 100644 --- a/nodeup/pkg/model/containerd.go +++ b/nodeup/pkg/model/containerd.go @@ -203,6 +203,7 @@ func (b *ContainerdBuilder) buildSystemdService(sv semver.Version) *nodetasks.Se manifest.Set("Service", "LimitNPROC", "infinity") manifest.Set("Service", "LimitCORE", "infinity") + manifest.Set("Service", "LimitNOFILE", "infinity") manifest.Set("Service", "TasksMax", "infinity") // make killing of processes of this unit under memory pressure very unlikely diff --git a/nodeup/pkg/model/tests/containerdbuilder/complex/tasks.yaml b/nodeup/pkg/model/tests/containerdbuilder/complex/tasks.yaml index 20bbfa8e4c5dc..8da8abbc034d3 100644 --- a/nodeup/pkg/model/tests/containerdbuilder/complex/tasks.yaml +++ b/nodeup/pkg/model/tests/containerdbuilder/complex/tasks.yaml @@ -362,6 +362,7 @@ definition: | RestartSec=5 LimitNPROC=infinity LimitCORE=infinity + LimitNOFILE=infinity TasksMax=infinity OOMScoreAdjust=-999 diff --git a/nodeup/pkg/model/tests/containerdbuilder/simple/tasks.yaml b/nodeup/pkg/model/tests/containerdbuilder/simple/tasks.yaml index 894f9143c5a53..53c73fc13dc1a 100644 --- a/nodeup/pkg/model/tests/containerdbuilder/simple/tasks.yaml +++ b/nodeup/pkg/model/tests/containerdbuilder/simple/tasks.yaml @@ -355,6 +355,7 @@ definition: | RestartSec=5 LimitNPROC=infinity LimitCORE=infinity + LimitNOFILE=infinity TasksMax=infinity OOMScoreAdjust=-999