-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presubmit checks for stable metrics #1833
Presubmit checks for stable metrics #1833
Comments
/open |
/reopen |
@CatherineF-dev: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@CatherineF-dev: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
/triage accepted |
What would you like to be added:
A presubmit to validate stable metrics don't change metric name, add labels or delete labels.
Similar to k8s stable metrics presubmit.
Why is this needed:
Guarantee stable metrics are stable.
Due to lack of presubmit check, some stable metrics are changed. For example,
kube_persistentvolume_info
is changed in feat: Add local storage labels to kube_persistentvolume_info #1814kube_service_status_load_balancer_ingress
is changed in Add default label of uid for service #1687Describe the solution you'd like
Additional context
The text was updated successfully, but these errors were encountered: