Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ingress status hostname #1366

Closed
ofen opened this issue Jan 26, 2021 · 14 comments · May be fixed by #2433
Closed

Support for ingress status hostname #1366

ofen opened this issue Jan 26, 2021 · 14 comments · May be fixed by #2433
Assignees
@slashpai
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@ofen
Copy link

ofen commented Jan 26, 2021

It would be great to have ability to collect metrics of ingress status from status.loadBalancer.ingress[] for ALB loadbalancer hostnames:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    alb.ingress.kubernetes.io/healthcheck-path: /health
    alb.ingress.kubernetes.io/inbound-cidrs: 10.0.0.0/8
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP":80}]'
    alb.ingress.kubernetes.io/scheme: internal
    kubernetes.io/ingress.class: public-alb
  generation: 1
  name: test
  namespace: kube-system
spec:
  backend:
    serviceName: my-service
    servicePort: 8080
status:
  loadBalancer:
    ingress:
    - hostname: internal-9a4003c3-kube-system-test-bbc4-1234567890.us-east-1.elb.amazonaws.com
@ofen ofen added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 26, 2021
@jeswinkninan
Copy link
Contributor

@lilic Can you please review this and assign the task to me if it is required

@lilic
Copy link
Member

lilic commented Feb 1, 2021

@ofen thanks for the feature request! Note we support networking.k8s.io/v1 ingress resource from v2.0 which is coming up and in which this feature would be included.

Have you seen the metric kube_service_status_load_balancer_ingress, it provides the hostname, would this be enough for you or do you need it tied to ingress object? https://github.com/kubernetes/kube-state-metrics/blob/fb48293a4012c16392f370e9ea8c77a1b66d24c3/docs/service-metrics.md

@ofen
Copy link
Author

ofen commented Feb 1, 2021

@ofen thanks for the feature request! Note we support networking.k8s.io/v1 ingress resource from v2.0 which is coming up and in which this feature would be included.

Have you seen the metric kube_service_status_load_balancer_ingress, it provides the hostname, would this be enough for you or do you need it tied to ingress object? https://github.com/kubernetes/kube-state-metrics/blob/fb48293a4012c16392f370e9ea8c77a1b66d24c3/docs/service-metrics.md

kube_service_status_load_balancer_ingress is empty in our case. Looks like its provide loadbalancer endpoint only if its described via service's EXTERNAL-IP.

@lilic
Copy link
Member

lilic commented Feb 5, 2021

Got it makes sense, then I have no problems with having this as long as the new metric does not produce an unbound number of series, judging by this it would be the number of ingress and hostname objects correct?

@lilic lilic added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 19, 2021
@slashpai
Copy link
Contributor

slashpai commented Jun 1, 2021

Checked if this is already implemented but didn't see changes. I would like to work on this issue. I am new to this so it might take some time to understand the codebase :)

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2021
@fpetkovski
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2021
@slashpai
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 28, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sumanthkumarc
Copy link

sumanthkumarc commented May 24, 2024 •
edited
Loading

+1 this would be really useful metric to tie the ingress to cloud balancer etc. For example tying the deployment -> ingress -> cloudwatch metrics

This was referenced Jun 26, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slashpai slashpai

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
8 participants
@ofen @fpetkovski @slashpai @lilic @sumanthkumarc @k8s-ci-robot @jeswinkninan @k8s-triage-robot