Skip to content

Commit 4dab035

Browse files
committed
test: Fix guest_env_test.go
The test used `go:build iso` so it was not included in the integration tests. Change to `go:build integration` so we test in the CI. Rename the file and the test name to make it more clear that this test is about the iso image. Skip the test for non vm-driver, since this tests is about the iso image. We may need to add a similar test or adapt this test so it can be used also with the kicbase image. This test will be useful to validate #21800, avoiding regressions such as #21788.
1 parent 5ca02f9 commit 4dab035

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

test/integration/guest_env_test.go renamed to test/integration/iso_test.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//go:build iso
1+
//go:build integration
22

33
/*
44
Copyright 2016 The Kubernetes Authors All rights reserved.
@@ -28,8 +28,12 @@ import (
2828
"k8s.io/minikube/pkg/minikube/vmpath"
2929
)
3030

31-
// TestGuestEnvironment verifies files and packages installed inside minikube ISO/Base image
32-
func TestGuestEnvironment(t *testing.T) {
31+
// TestISOImage verifies files and packages installed inside minikube ISO/Base image
32+
func TestISOImage(t *testing.T) {
33+
if !VMDriver() {
34+
t.Skip("This test requires a VM driver")
35+
}
36+
3337
MaybeParallel(t)
3438

3539
profile := UniqueProfileName("guest")

0 commit comments

Comments
 (0)