Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed hardcoded 1.31 version for compatibility-versions-e2e.yaml test and properly parameterize the n-1..3 release branch #33573

Open
aaron-prindle opened this issue Oct 3, 2024 · 1 comment · May be fixed by #33837
Open

Removed hardcoded 1.31 version for compatibility-versions-e2e.yaml test and properly parameterize the n-1..3 release branch #33573

aaron-prindle opened this issue Oct 3, 2024 · 1 comment · May be fixed by #33837
Assignees
@aaron-prindle
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@aaron-prindle
Copy link
Contributor

Currently config/jobs/kubernetes/sig-testing/compatibility-versions-e2e.yaml has the hardcoded value:

     env:
      - name: EMULATED_VERSION
        value: "1.31"  # TODO(aaron-prindle) FIXME - hardcoded for now

For selecting the emulation version and currently in experiment/compatibility-versions/e2e-k8s-compatibility-versions.sh the k8s branch to clone is parameterized BUT not set in ``compatibility-versions-e2e.yaml`

  KUBE_RELEASE_BRANCH=${KUBE_RELEASE_BRANCH:-release-1.31}

This issue tracks properly parameterizing this. See related PR comment here:
#33534 (comment)

which mentions that using https://github.com/kubernetes/test-infra/tree/master/releng/config-forker might be a good solution here

/assign @aaron-prindle
@aaron-prindle aaron-prindle added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 3, 2024
@aaron-prindle aaron-prindle mentioned this issue Oct 3, 2024
Merged
@aaron-prindle
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2024
@aaron-prindle aaron-prindle linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaron-prindle aaron-prindle

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
2 participants
@aaron-prindle @k8s-ci-robot