Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention graceful_node_shutdown_state in kubelet local files page #48610

Open
SergeyKanzhelev opened this issue Oct 31, 2024 · 4 comments · May be fixed by #48747
Open

Mention graceful_node_shutdown_state in kubelet local files page #48610

SergeyKanzhelev opened this issue Oct 31, 2024 · 4 comments · May be fixed by #48747
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@SergeyKanzhelev
Copy link
Member

This is a Bug Report

Problem:

The file is not mentioned on the page https://kubernetes.io/docs/reference/node/kubelet-files/

Proposed Solution:
Add a mention of the file graceful_node_shutdown_state

Page to Update:
https://kubernetes.io/docs/reference/node/kubelet-files/

@SergeyKanzhelev SergeyKanzhelev added the kind/bug Categorizes issue or PR as related to a bug. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 31, 2024
@a-mccarthy
Copy link
Contributor

/priority backlog
/language en
/triage accepted
/help

thanks for filing @SergeyKanzhelev, can you share a little more about this file or where someone can look into learning more about it for the docs. thanks!

@k8s-ci-robot
Copy link
Contributor

@a-mccarthy:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/priority backlog
/language en
/triage accepted
/help

thanks for filing @SergeyKanzhelev, can you share a little more about this file or where someone can look into learning more about it for the docs. thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 1, 2024
@pegasas
Copy link
Contributor

pegasas commented Nov 6, 2024

/assign @pegasas

@network-charles
Copy link
Contributor

Hi @a-mccarthy, it can be found here.

git clone https://github.com/kubernetes/kubernetes.git
cd kubernetes
grep -rnw . -e "graceful_node_shutdown_state"

./pkg/kubelet/nodeshutdown/storage_test.go:27:  var localStorageStateFileName = "graceful_node_shutdown_state"
./pkg/kubelet/nodeshutdown/nodeshutdown_manager.go:88:  localStorageStateFile          = "graceful_node_shutdown_state"
./test/e2e_node/node_shutdown_linux_test.go:561:                        stateFile := "/var/lib/kubelet/graceful_node_shutdown_state"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants