Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Bump apiVersion of opentelemetry collector #474

Open
viccuad opened this issue Jun 25, 2024 · 3 comments · Fixed by #479
Open

Feature Request: Bump apiVersion of opentelemetry collector #474

viccuad opened this issue Jun 25, 2024 · 3 comments · Fixed by #479

Comments

@viccuad
Copy link
Member

viccuad commented Jun 25, 2024

From Martin:

Here we use apiVersion: opentelemetry.io/v1alpha1 but in 0.102.0 there is v1beta1. The deployment seems to work well but Fleet seems to have a problem to compare properly. Is there a chance to change this to v1beta1?

Acceptance criteria

  • Bump mentioned apiVersion in our opentelemetry collector instance.
  • Make sure spec.Config matches the new schema for v1beta1 version of the spec.
  • Perform opentelemetry tests and verify everything is fine.
  • Perform upgrade test on a deployment with opentelemetry and verify that everything is fine.
  • Make sure that the pinned versions of the charts for the telemetetry stack in docs.kubewarden.io match the minimum versions needed for this feature.
@flavio
Copy link
Member

flavio commented Jun 26, 2024

I would tackle this change together with the bumps of the otel crates

@viccuad viccuad moved this to Todo in Kubewarden Jul 5, 2024
@viccuad viccuad self-assigned this Jul 5, 2024
@viccuad viccuad moved this from Todo to In Progress in Kubewarden Jul 5, 2024
@viccuad viccuad moved this from In Progress to Pending review in Kubewarden Jul 10, 2024
@github-project-automation github-project-automation bot moved this from Pending review to Done in Kubewarden Jul 10, 2024
@viccuad viccuad reopened this Jul 29, 2024
@viccuad
Copy link
Member Author

viccuad commented Jul 29, 2024

Reopening; the change was reverted, and it seems the template for the CR needs adjustment as there are spec changes in spec.config besides the apiVersion bump: (edited acceptance criteria)

Error: 1 error occurred:
        * admission webhook "mopentelemetrycollectorbeta.kb.io" denied the request: json: cannot unmarshal string into Go struct field OpenTelemetryCollectorSpec.spec.config of type v1beta1.Config

@viccuad
Copy link
Member Author

viccuad commented Jul 29, 2024

IMHO we need to wait for this feature request, as the minimum dependency versions we list at https://docs.kubewarden.io/reference/dependency-matrix will of course not support this change.

Given that the current latest chart, opentelemetry-operator-0.64.0, is still accepting v1alpha1, and provides the apiVersion migration, I think it's fine to wait.

@viccuad viccuad removed this from the 1.15 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants