Use config structs to initialize reconcilers in the main setup function

[fabriziosestito]

Currently, we rely on several initialization functions to set up reconcilers, webhooks, and manager-related resources. These functions accept numerous parameters—and in some cases, they directly inject them into the reconcilers. This approach, however, isn’t very ergonomic. Instead, we could generate configuration structs from the CLI and use them to propagate the configuration variables in a cleaner wa.

Setup Functions:

• setupManager:

  kubewarden-controller/cmd/main.go

  Line 184 in a3ce83c

  func setupManager(deploymentsNamespace string, metricsAddr string, probeAddr string, enableLeaderElection bool) (ctrl.Manager, error) {

• setupReconcilers:

  kubewarden-controller/cmd/main.go

  Line 244 in a3ce83c

  func setupReconcilers(mgr ctrl.Manager, deploymentsNamespace, webhookServiceName string, alwaysAcceptAdmissionReviewsOnDeploymentsNamespace, featureGateAdmissionWebhookMatchConditions bool, otelConfiguration controller.TelemetryConfiguration) error {

• setupWebhooks:

  kubewarden-controller/cmd/main.go

  Line 309 in a3ce83c

  func setupWebhooks(mgr ctrl.Manager, deploymentsNamespace string) error {

Example

func main() {
  // parse CLI flags

    config := Configuration{
        DeploymentsNamespace: deploymentsNamespace,
        WebhookServiceName: webhookServiceName,
        AlwaysAcceptAdmissionReviewsOnDeploymentsNS: alwaysAcceptAdmissionReviewsOnDeploymentsNamespace,
        FeatureGateAdmissionWebhookMatchConditions: featureGateAdmissionWebhookMatchConditions,
        Telemetry: otelConfiguration,
        MutualTLS: MTLSConfig{
            Enabled: enableMutualTLS,
            ClientCAConfigMapName: clientCAConfigMapName,
            ClientCAConfigMapNS: clientCAConfigMapNamespace,
        },
    }

    mgrOpts := ManagerOptions{
        MetricsAddr: metricsAddr,
        ProbeAddr: probeAddr,
        EnableLeaderElection: enableLeaderElection,
        DeploymentsNamespace: deploymentsNamespace,
        EnableMutualTLS: enableMutualTLS,
    }

    mgr, err := setupManager(mgrOpts)
    if err != nil {
        // handle error
    }

    if err := setupReconcilers(mgr, config); err != nil {
        // handle error
    }

    if err := setupWebhooks(mgr, config.DeploymentsNamespace); err != nil {
        // handle error
    }
}

func setupReconciler(mgr mgr, config Configuration) {
  reconciler := SomethingReconciler {
    Config: Configuration,
    ... // other dependencies
  }
}