Add installation checks

kuler90 · Nov 13, 2020 · 4a6fea8 · 4a6fea8
1 parent c25ca34
commit 4a6fea8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -9,6 +9,7 @@ jobs:
   test:
     runs-on: ${{ matrix.os }}
     strategy:
+      fail-fast: false
       matrix:
         os:
           - ubuntu-latest

diff --git a/src/setup.js b/src/setup.js
@@ -88,14 +88,20 @@ async function installUnityEditor(unityHubPath, installPath, unityVersion, unity
         }
         await executeHub(unityHubPath, `install --version ${unityVersion} --changeset ${unityVersionChangeset}`);
         unityPath = await findUnity(unityHubPath, unityVersion);
+        if (!unityPath) {
+            throw new Error('unity editor installation failed');
+        }
     }
     return unityPath;
 }
 
 async function installUnityModules(unityHubPath, unityVersion, unityModules, unityModulesChild) {
     const modulesArgs = unityModules.map(s => `--module ${s.toLowerCase()}`).join(' ');
     const childModulesArg = unityModulesChild ? '--childModules' : '';
-    await executeHub(unityHubPath, `install-modules --version ${unityVersion} ${modulesArgs} ${childModulesArg}`);
+    const stdout = await executeHub(unityHubPath, `install-modules --version ${unityVersion} ${modulesArgs} ${childModulesArg}`);
+    if (!stdout.includes('successfully')) {
+        throw new Error('unity modules installation failed');
+    }
 }
 
 async function postInstall() {