Allow NaN and Inf values to pass through Stack push/get/isInstance

Agent-Logs-Url: https://github.com/kunitoki/LuaBridge3/sessions/35478d43-613d-42fb-8556-4fffe1634e91

Co-authored-by: kunitoki <707032+kunitoki@users.noreply.github.com>

Author: Copilot

.gitignore

@@ -14,3 +14,4 @@ build/
 .DS_store
 .idea/
 cmake-build-*/
+tmpunwind.o

Distribution/LuaBridge/LuaBridge.h

@@ -9,6 +9,7 @@
 #include <algorithm>
 #include <array>
 #include <cassert>
+#include <cmath>
 #include <cstddef>
 #include <cstdint>
 #include <cstdio>
@@ -689,8 +690,11 @@ bool is_integral_representable_by(lua_State* L, int index)
 }
 
 template <class U = lua_Number, class T>
-constexpr bool is_floating_point_representable_by(T value)
+bool is_floating_point_representable_by(T value)
 {
+    if (std::isnan(value) || std::isinf(value))
+        return true;
+
     if constexpr (sizeof(T) == sizeof(U))
         return true;
 

Source/LuaBridge/detail/LuaHelpers.h

@@ -8,6 +8,7 @@
 
 #include "Config.h"
 
+#include <cmath>
 #include <cstdint>
 #include <cstdio>
 #include <cstdlib>
@@ -662,8 +663,11 @@ bool is_integral_representable_by(lua_State* L, int index)
  * @brief Checks if the value on the stack is a number type and can fit into the corresponding c++ numerical type..
  */
 template <class U = lua_Number, class T>
-constexpr bool is_floating_point_representable_by(T value)
+bool is_floating_point_representable_by(T value)
 {
+    if (std::isnan(value) || std::isinf(value))
+        return true;
+
     if constexpr (sizeof(T) == sizeof(U))
         return true;
 

Tests/Source/StackTests.cpp

@@ -1404,6 +1404,108 @@ TEST_F(StackTests, FloatTypeNotFittingIsInstance)
     EXPECT_TRUE(luabridge::isInstance<long double>(L, 1));
 }
 
+TEST_F(StackTests, FloatNaNAndInfPush)
+{
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, std::numeric_limits<float>::quiet_NaN()));
+        EXPECT_TRUE(luabridge::isInstance<float>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<double>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<long double>(L, -1));
+        auto result = luabridge::get<float>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isnan(*result));
+    }
+
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, std::numeric_limits<float>::infinity()));
+        EXPECT_TRUE(luabridge::isInstance<float>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<double>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<long double>(L, -1));
+        auto result = luabridge::get<float>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isinf(*result));
+    }
+
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, -std::numeric_limits<float>::infinity()));
+        auto result = luabridge::get<float>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isinf(*result));
+        EXPECT_LT(*result, 0.0f);
+    }
+}
+
+TEST_F(StackTests, DoubleNaNAndInfPush)
+{
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, std::numeric_limits<double>::quiet_NaN()));
+        EXPECT_TRUE(luabridge::isInstance<float>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<double>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<long double>(L, -1));
+        auto result = luabridge::get<double>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isnan(*result));
+    }
+
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, std::numeric_limits<double>::infinity()));
+        EXPECT_TRUE(luabridge::isInstance<float>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<double>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<long double>(L, -1));
+        auto result = luabridge::get<double>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isinf(*result));
+    }
+
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, -std::numeric_limits<double>::infinity()));
+        auto result = luabridge::get<double>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isinf(*result));
+        EXPECT_LT(*result, 0.0);
+    }
+}
+
+TEST_F(StackTests, LongDoubleNaNAndInfPush)
+{
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, std::numeric_limits<long double>::quiet_NaN()));
+        EXPECT_TRUE(luabridge::isInstance<float>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<double>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<long double>(L, -1));
+        auto result = luabridge::get<long double>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isnan(*result));
+    }
+
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, std::numeric_limits<long double>::infinity()));
+        EXPECT_TRUE(luabridge::isInstance<float>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<double>(L, -1));
+        EXPECT_TRUE(luabridge::isInstance<long double>(L, -1));
+        auto result = luabridge::get<long double>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isinf(*result));
+    }
+
+    {
+        const luabridge::StackRestore sr(L);
+        EXPECT_TRUE(luabridge::push(L, -std::numeric_limits<long double>::infinity()));
+        auto result = luabridge::get<long double>(L, -1);
+        ASSERT_TRUE(result);
+        EXPECT_TRUE(std::isinf(*result));
+        EXPECT_LT(*result, 0.0l);
+    }
+}
+
 TEST_F(StackTests, CharArrayType)
 {
     char value[] = "xyz";