clean up

Author: 9034725985

src/MyOpenTelemetryApi.Api/Telemetry/FileExporter.cs

@@ -8,7 +8,7 @@ namespace MyOpenTelemetryApi.Api.Telemetry;
 public class FileLogExporter : BaseExporter<LogRecord>
 {
     private readonly string _filePath;
-    private readonly object _lockObject = new();
+    private readonly Lock _lockObject = new();
     private readonly JsonSerializerOptions _jsonOptions;
 
     public FileLogExporter(string filePath)
@@ -40,14 +40,14 @@ public override ExportResult Export(in Batch<LogRecord> batch)
                 {
                     var logEntry = new
                     {
-                        Timestamp = logRecord.Timestamp,
+                        logRecord.Timestamp,
                         TraceId = logRecord.TraceId.ToString(),
                         SpanId = logRecord.SpanId.ToString(),
                         TraceFlags = logRecord.TraceFlags.ToString(),
-                        CategoryName = logRecord.CategoryName,
+                        logRecord.CategoryName,
                         LogLevel = logRecord.LogLevel.ToString(),
-                        FormattedMessage = logRecord.FormattedMessage,
-                        Body = logRecord.Body,
+                        logRecord.FormattedMessage,
+                        logRecord.Body,
                         ScopeValues = ExtractScopeValues(logRecord),
                         Exception = logRecord.Exception?.ToString(),
                         Attributes = ExtractAttributes(logRecord)
@@ -67,7 +67,7 @@ public override ExportResult Export(in Batch<LogRecord> batch)
         }
     }
 
-    private List<object> ExtractScopeValues(LogRecord logRecord)
+    private static List<object> ExtractScopeValues(LogRecord logRecord)
     {
         var scopes = new List<object>();
 
@@ -82,7 +82,7 @@ private List<object> ExtractScopeValues(LogRecord logRecord)
         return scopes;
     }
 
-    private Dictionary<string, object?> ExtractAttributes(LogRecord logRecord)
+    private static Dictionary<string, object?> ExtractAttributes(LogRecord logRecord)
     {
         var attributes = new Dictionary<string, object?>();
 

src/MyOpenTelemetryApi.Api/Telemetry/TelemetryExtensions.cs

@@ -22,7 +22,7 @@ public static TracerProviderBuilder AddFileExporter(
         var enabled = configuration.GetValue<bool>("OpenTelemetry:Exporter:File:Enabled");
         if (enabled)
         {
-            var tracePath = configuration.GetValue<string>("OpenTelemetry:Exporter:File:TracePath") 
+            _ = configuration.GetValue<string>("OpenTelemetry:Exporter:File:TracePath")
                            ?? "logs/otel-traces.json";
             // For traces, we'd implement a similar FileTraceExporter
             // For now, we'll use console exporter as file trace export is complex

src/MyOpenTelemetryApi.Application/Services/ContactService.cs

@@ -318,7 +318,7 @@ public async Task<List<ContactSummaryDto>> GetByTagAsync(Guid tagId)
         return results;
     }
 
-    private ContactDto MapToDto(Contact contact)
+    private static ContactDto MapToDto(Contact contact)
     {
         return new ContactDto
         {

src/MyOpenTelemetryApi.Application/Services/GroupService.cs

@@ -74,7 +74,7 @@ public async Task<bool> DeleteAsync(Guid id)
         return true;
     }
 
-    private GroupDto MapToDto(Group group)
+    private static GroupDto MapToDto(Group group)
     {
         return new GroupDto
         {