Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default spectrapply() should not include index #45

Closed
kuwisdelu opened this issue Aug 4, 2024 · 0 comments
Closed

Default spectrapply() should not include index #45

kuwisdelu opened this issue Aug 4, 2024 · 0 comments

Comments

@kuwisdelu
Copy link
Owner

kuwisdelu commented Aug 4, 2024

The current defaults for spectrapply() pass along an index/domain variable as the second argument. For MSI, the default is "mz", and for generic spectra it is a dummy ordinal index.

This requires creating wrappers for basic summary functions like sum() that will include all unnamed variables passed to them in their computation. Obviously, needing wrappers for basic summarization adds unnecessary complexity.

We should change the default to index=NULL not passing any additional variables to the spectrapply() function.

kuwisdelu added a commit that referenced this issue Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant