Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary signal length in count_leading_zeros #751

Open
tilk opened this issue Nov 12, 2024 · 3 comments
Open

Support arbitrary signal length in count_leading_zeros #751

tilk opened this issue Nov 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tilk
Copy link
Member

tilk commented Nov 12, 2024

Currently this function requires power of 2 length.

@tilk tilk added enhancement New feature or request good first issue Good for newcomers labels Nov 12, 2024
@piotro888
Copy link
Member

  • update PriorityEncoder to use more efficient count_leading_zeros instead of m.If loop
  • refactor FPURounding to use new count_leading_zeros

@Hazardu
Copy link
Contributor

Hazardu commented Nov 26, 2024

I will open a PR solving the issue sometime this week.

@Durchbruchswagen would you like the PR to target #741 instead of master branch to also do things like removing nearestpow2 that you had to add there?

@Durchbruchswagen
Copy link
Contributor

I will open a PR solving the issue sometime this week.

@Durchbruchswagen would you like the PR to target #741 instead of master branch to also do things like removing nearestpow2 that you had to add there?

If this isn't too big of an issue for you, then sure, go ahead and target #741.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants