Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FuncUnit to remove duplicate code #793

Open
Hazardu opened this issue Jan 25, 2025 · 0 comments · May be fixed by #803
Open

Refactor FuncUnit to remove duplicate code #793

Hazardu opened this issue Jan 25, 2025 · 0 comments · May be fixed by #803

Comments

@Hazardu
Copy link
Contributor

Hazardu commented Jan 25, 2025 •
edited
Loading

It appears that a lot of code in FuncUnit derived classes is duplicated,

Indeed. This could probably be resolved by adding a base class for FUs, which would include a common constructor. This is not the subject of this PR, however - maybe you would be interested in doing such a refactor?

Originally posted by @tilk in #792 (comment)
@Hazardu Hazardu linked a pull request Feb 13, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicated FuncUnit kuznia-rdzeni/coreblocks
1 participant
@Hazardu