Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we need to disable CUDA graph (enforce_eager) for Tensor parallelism? #64

Open
skyCreateXian opened this issue Jan 6, 2025 · 1 comment

Comments

@skyCreateXian
Copy link

As shown in the question, in the Mooncake document:
Option --tensor_parallel_size \ -tp is supported now. But you need to set up --enforce_eager to disable cuda graph. Example: append -tp 2 --enforce_eager to the run command.

My question is why it is necessary to disable CUDA graphics, as this results in a loss of performance. What are the technical difficulties in adapting CUDA static graphics?

@ShangmingCai
Copy link
Collaborator

As shown in the question, in the Mooncake document: Option --tensor_parallel_size \ -tp is supported now. But you need to set up --enforce_eager to disable cuda graph. Example: append -tp 2 --enforce_eager to the run command.

My question is why it is necessary to disable CUDA graphics, as this results in a loss of performance. What are the technical difficulties in adapting CUDA static graphics?

This is a legacy issue. In previous versions, when tp=4 and we enable disaggregated prefilling distributed env and cuda graph at the same time, some errors will come up in cuda graph initialization. After testing, this issue has been fixed in recent versions of vllm.

I will modify the document. Thank you for the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants