Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer to peer code review #8

Open
Profsain opened this issue Jun 9, 2022 · 1 comment
Open

Peer to peer code review #8

Profsain opened this issue Jun 9, 2022 · 1 comment

Comments

@Profsain
Copy link

Profsain commented Jun 9, 2022

You have done a great job. Your code looks clean and uses ES6 syntax properly.
Below are suggestions for improving your project.

  • It is better to use onmouseout event listener for edit functionality as well to avoid ambiguity.
  • It is more professional to throw a flash message like "You have no completed task" if there is no completed task in the list when clicking the "clear all completed"
@kwekubright
Copy link
Owner

Thanks @Profsain for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwekubright @Profsain