Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't apply table-sort-js if website already running a table sorter (browser extensions) #102

Open
kyle-wannacott opened this issue May 21, 2023 · 3 comments

Comments

@kyle-wannacott
Copy link
Owner

https://en.wikipedia.org/wiki/List_of_TCP_and_UDP_port_numbers

This table is already using sortable and jquery-tablesorter classes we should check for sorting classes from other libraries before running table sort js. If they exist don't run table-sort-js...

@kyle-wannacott kyle-wannacott changed the title If another table sorting library is being used don't apply table-sort-js (browser extensions) Don't apply table-sort-js if website already running a table sorting plugin (browser extensions) May 21, 2023
@kyle-wannacott kyle-wannacott changed the title Don't apply table-sort-js if website already running a table sorting plugin (browser extensions) Don't apply table-sort-js if website already running a table sorter (browser extensions) May 21, 2023
@kyle-wannacott
Copy link
Owner Author

Or do we be evil and remove other libraries table class tags 🦹

@scodes73
Copy link
Contributor

Or do we be evil and remove other libraries table class tags supervillain

How about we give a toggle for user to pick it?

@kyle-wannacott
Copy link
Owner Author

@scodes73 Yeah that sounds good; it's what I was thinking. Default don't run if other sorting libraries would be helpful for the browser plugins (which currently have no configurability by users) and then a class for overriding libraries if they exist: evil-supervillian-mode!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants