Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table arrows do not disappear #140

Open
ccapndave opened this issue Nov 28, 2024 · 3 comments
Open

Table arrows do not disappear #140

ccapndave opened this issue Nov 28, 2024 · 3 comments

Comments

@ccapndave
Copy link

If I enable table-arrows, clicking on column 1 shows an arrow as expected. However, clicking on column 2 shows the arrow for column 2 and column 1. I think that only one arrow should be visible at a time.

@kyle-wannacott
Copy link
Owner

@ccapndave which version is this? I did changes in the latest release for custom table arrows, so it might be a regression. Can you compare v1.21.0 to v1.22.1 ;I don't remember exactly what the behaviour was... 🛌🏻

@ccapndave
Copy link
Author

Thanks for the quick response! This is on 1.22.1. I checked on 1.12.0 and the behaviour is the same.

@kyle-wannacott
Copy link
Owner

kyle-wannacott commented Nov 29, 2024

@ccapndave I don't think the table arrows should disappear?, however if clicking on another column it should reset all table arrows to the neutral arrow before setting the arrow up/down on the column being sorted (I'm guessing this is what you want???); however, the current implementation should still apply when the "remember-sort" tag is applied (not that anybody probably uses this tag...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants