Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move verify images from beta to GA #8914

Closed
2 tasks done
vishal-chdhry opened this issue Nov 15, 2023 · 5 comments
Closed
2 tasks done

[Feature] Move verify images from beta to GA #8914

vishal-chdhry opened this issue Nov 15, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request imageVerify Image verification support release-high High issues which SHOULD be addressed in the specified milestone. These may get bumped.

Comments

@vishal-chdhry
Copy link
Member

Problem Statement

Verify image rules are currently in beta for sometime. Since then several features have been added and the approach have been refined. We have gotten to the point where we should consider bumping verify image rules to stable.

Solution Description

Move verify image rules to stable

Alternatives

No response

Additional Context

No response

Slack discussion

No response

Research

  • I have read and followed the documentation AND the troubleshooting guide.
  • I have searched other issues in this repository and mine is not recorded.
@vishal-chdhry vishal-chdhry added enhancement New feature or request triage Default label assigned to all new issues indicating label curation is needed to fully organize. labels Nov 15, 2023
@vishal-chdhry vishal-chdhry added this to the Kyverno Release 1.12.0 milestone Nov 15, 2023
Copy link

welcome bot commented Nov 15, 2023

Thanks for opening your first issue here! Be sure to follow the issue template!

@vishal-chdhry vishal-chdhry self-assigned this Nov 16, 2023
@realshuting realshuting added imageVerify Image verification support and removed triage Default label assigned to all new issues indicating label curation is needed to fully organize. labels Nov 17, 2023
@realshuting realshuting changed the title [Feature] Move verify images from beta to stable [Feature] Move verify images from beta to GA May 7, 2024
@realshuting
Copy link
Member

realshuting commented May 7, 2024

@vishal-chdhry - what is required to support Image Verification GA?

We also need to upgrade to the Sigstore library, is there a tracking issue?

@vishal-chdhry
Copy link
Member Author

To move verify images to GA we have to do the following:

  1. Support for concurrent image verification: There is a KDP for that - feat: image verify performance enhancements KDP#58
  2. Move to sigstore-go: As of now, cosign uses a custom signature bundle format which is not directly compatible with sigstore-go. A newer specification for storing Sigstore Bundles has been accepted, which utilizes the OCI 1.1 Manifest Referrers API to attach Sigstore Bundles as referring artifacts to an image. Additionally, GitHub Artifact Attestations attach Sigstore Bundles following the spec, and kyverno cannot verify these attestations.
    Things I have to work on are:
    1. Add the sigstore bundle support in sigstore/cosign.
    2. Add a signature format option in cosign verify image to support the old simplesigning format and the sigstore bundle

@realshuting realshuting added release-critical Critical issues which MUST be addressed in the specified milestone. These cannot get bumped. release-high High issues which SHOULD be addressed in the specified milestone. These may get bumped. and removed release-critical Critical issues which MUST be addressed in the specified milestone. These cannot get bumped. labels Jul 23, 2024
@vishal-chdhry vishal-chdhry moved this to In Progress in Kyverno Release Tracker Jul 29, 2024
@realshuting
Copy link
Member

@vishal-chdhry - can we close the issue?

@vishal-chdhry
Copy link
Member Author

@realshuting yes, all the action items except concurrency in image verification has been completed and that is not a requirement for GA and is tracked by another issue

@github-project-automation github-project-automation bot moved this from Code Complete to Done in Kyverno Release Tracker Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request imageVerify Image verification support release-high High issues which SHOULD be addressed in the specified milestone. These may get bumped.
Projects
Development

No branches or pull requests

3 participants