Add Cache-Control header option to Advanced Settings

[bkietz]

Files are never getting cached, so they're slow to load. It would be nice to be able to set a header and allow caching for when I have massive files (these ones are taking ~5s every time).

[kzahel]

Yes caching would be good. I admit to know very little about HTTP caching. Do I send over the modified time of the file in the header, along with some kind of "check every 10min" or "check every 60day" supplemental header?

[bkietz]

https://developer.mozilla.org/en-US/docs/Web/HTTP/Caching#Expiration

Setting a header like Cache-Control: public, max-age=600 should signal browsers to cache for 10min unless flushed.

Allowing the duration to be adjustable through an <input/> is probably a good idea too.

[jamiesanger]

Id be keen to see Last-Modified header though. Service Workers can possibly compare modified dates from an IDB or similar to only update changed (and new) files.

[kzahel]

Yeah I think if I do a sha1 or similar of the file and send an etag header that should allow for if modified since? I'm not really clear on the details but hopefully I should find some time to look into it

…

On Feb 12, 2018 5:22 PM, "Jamie Sanger" ***@***.***> wrote: Id be keen to see Last-Modified header though. Service Workers can possibly compare modified dates from an IDB or similar to only update changed (and new) files. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#130 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJqkKIuXSqrilrbDaMkoMJqq2U6S86mks5tUOPugaJpZM4R9FnP> .