Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze when failing to change resolution on webcam #19

Open
arthurzenika opened this issue Mar 13, 2017 · 3 comments
Open

Freeze when failing to change resolution on webcam #19

arthurzenika opened this issue Mar 13, 2017 · 3 comments
Assignees
Labels

Comments

@arthurzenika
Copy link

$ npm start

> [email protected] start /home/arthur/local/carreau.js
> electron .

Not logging to a file
[11:21:40] ——— Starting carreaujs app v1.0.0
[11:21:40] Found defaults for windowState: 
[11:21:40] [object Object]
[11:21:40] global.nodeStorage.getItem("userDirPath") : null
[11:21:40] No usable userDirPath, using default
[11:21:40] Content folder carreau-js does not already exists in /home/arthur/Documents
[11:21:40] ->duplicating /user to create a new one
[11:21:40] Will store contents in: /home/arthur/Documents/carreau-js
main module initialized
1489400500
20170313_112140
[11:21:40] Initializing socket module
[11:21:40] Server up and running. Go to https://localhost:8080
[11:21:40]  
EVENT - onListConf
[11:21:42] RECEIVED EVENT : listConf
Number of folders in /home/arthur/Documents/carreau-js = 1. Folders are demo-carreau-js
COMMON — getFolderMeta for demo-carreau-js
COMMON — getMetaFileOfFolder /home/arthur/Documents/carreau-js/demo-carreau-js
- - - - all folders JSON have been processed.
eventAndContentJson {"socketevent":"listAllFolders","content":[{"name":"demo carreau.js","content":"","introduction":"<p>Hello world, this is <em>markdown</em></p>","lieu":"Here","date":"2016-08-31","auteur":"Louis","created":"20160831_191351","slides":["couv-num","rapport-e-o-a","lepo-caract","cnap-xyp-video-3","https-louiseveillard-com"],"slugFolderName":"demo-carreau-js"}]}
New Conf: [object Object]
COMMON — createNewFolder
[11:22:10] RECEIVED EVENT : newConf
New conf created with name Salt stackers and path /home/arthur/Documents/carreau-js/salt-stackers
COMMON — getMetaFileOfFolder /home/arthur/Documents/carreau-js/salt-stackers
Will store data
sucess [object Object]
newpdata: [object Object]
eventAndContentJson {"socketevent":"confCreated","content":{"name":"Salt stackers","content":"","introduction":"Hello world","lieu":"Nantes","date":"2017-01-01","auteur":"Arthur Lutz","created":"20170313_112210"}}
EVENT - onListConf
[11:22:11] RECEIVED EVENT : listConf
Number of folders in /home/arthur/Documents/carreau-js = 2. Folders are demo-carreau-js,salt-stackers
COMMON — getFolderMeta for demo-carreau-js
COMMON — getMetaFileOfFolder /home/arthur/Documents/carreau-js/demo-carreau-js
COMMON — getFolderMeta for salt-stackers
COMMON — getMetaFileOfFolder /home/arthur/Documents/carreau-js/test
- - - - all folders JSON have been processed.
eventAndContentJson {"socketevent":"listAllFolders","content":[{"name":"demo carreau.js","content":"","introduction":"<p>Hello world, this is <em>markdown</em></p>","lieu":"Here","date":"2016-08-31","auteur":"Louis","created":"20160831_191351","slides":["couv-num","rapport-e-o-a","lepo-caract","cnap-xyp-video-3","https-louiseveillard-com"],"slugFolderName":"demo-carreau-js"},{"name":"test","content":"","introduction":"Hello world","lieu":"Nantes","date":"2017-01-01","auteur":"Arthur Lutz","created":"20170313_112210","slugFolderName":"test"}]}
[11:22:14] RECEIVED EVENT : listSlides
[11:22:14] ERROR! Unhandled Rejection at: Promise ,[object Promise], reason: ,TypeError: Cannot read property 'length' of undefined

screenshot_2017-03-13_11-25-39

screenshot_2017-03-13_11-27-12

I don't think my webcam does the highest resolution.

"View > Reload" gets you out.

@louis-ev
Copy link
Member

Resolution are basically presets. Most cameras don't do 1920*1080, but getting the available camera resolutions takes a while and is hardly ideal with the current web technologies: https://webrtchacks.github.io/WebRTC-Camera-Resolution/

Maybe attempting to switch to lower resolution when one isn't working?

@arthurzenika
Copy link
Author

lower resolutions work, no problem. Don't hack on this, it's not something I use extensively. Maybe just catch the error and avoid freezing.

@louis-ev
Copy link
Member

Ok yeah, I didn't get that the window would basically freeze and be unusable.
Fixing this for next version. Thanks for the feedback.

@louis-ev louis-ev self-assigned this Mar 13, 2017
@louis-ev louis-ev added this to the carreau.js 2.0.0 milestone Mar 13, 2017
@louis-ev louis-ev added the bug label Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants