Skip to content

Commit f2e4f60

Browse files
committed
Fixing issues
1 parent d48c0bd commit f2e4f60

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

src/backend/TestData.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,9 @@ function getIdentifiers(id) {
303303
function getSubject(id: string, evidencePrefix: string) {
304304
return new Subject(getConclusion(id))
305305
.setExtracted(faker.datatype.boolean())
306-
.addEvidence(new EvidenceReference().setResource(`#${evidencePrefix}1`))
306+
.addEvidence(new EvidenceReference()
307+
.setAttribution(getAttribution())
308+
.setResource(`#${evidencePrefix}1`))
307309
.addEvidence(new EvidenceReference().setResource(`#${evidencePrefix}2`))
308310
.addMedia(new SourceReference().setDescription("#s1"))
309311
.addMedia(new SourceReference().setDescription("#s2"))

src/components/GedcomXComponents.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export function Notes({noMargin, notes}: { notes: gedcomX.Note[], noMargin?: boo
2727
{notes.map((note, i) =>
2828
<Article emoji="" title={note.getSubject()} key={i}>
2929
<P>{note.getText()}</P>
30-
{note.getAttribution() && <P><Attribution attribution={note.getAttribution()}/></P>}
30+
{note.getAttribution() && <Attribution attribution={note.getAttribution()}/>}
3131
</Article>)}
3232
</ArticleCollection>
3333
}
@@ -109,7 +109,7 @@ export function SourceReference({reference}: { reference: gedcomX.SourceReferenc
109109
<P><ReactLink to={`/sources/${reference.description.substring(1)}`}>
110110
{sourceTitle || reference.description}
111111
</ReactLink></P>
112-
{reference.attribution && <P><Attribution attribution={reference.attribution}/></P>}
112+
{reference.attribution && <Attribution attribution={reference.attribution}/>}
113113
</Article>
114114
}
115115

@@ -209,7 +209,7 @@ export function Evidence({evidenceReferences}) {
209209
<Title emoji={emojis.evidence}>{strings.gedcomX.subject.evidence}</Title>
210210
{evidenceReferences.map((evidence, i) =>
211211
<Article key={i}>
212-
<ReactLink to={linkTarget + evidence.resource.substring(1)}>{evidence.resource}</ReactLink>
212+
<P><ReactLink to={linkTarget + evidence.resource.substring(1)}>{evidence.resource}</ReactLink></P>
213213
<Attribution attribution={evidence.attribution}/>
214214
</Article>)}
215215
</ArticleCollection>
@@ -223,9 +223,9 @@ export function SubjectArticles({subject, noMargin}: { subject: gedcomX.Subject,
223223

224224
return <>
225225
{media && media.length > 0 && <Gallery noMargin={noMargin}>
226-
{media.map(m => {
226+
{media.map((m, i) => {
227227
let credit = m.getCitations()[0].getValue();
228-
return <div className="relative">
228+
return <div className="relative" key={i}>
229229
<Media mimeType={m.mediaType} url={m.getAbout()}
230230
alt={m.getDescriptions().filter(filterLang)[0]?.getValue()}/>
231231
<div className={"absolute bottom-0 py-1 px-4 w-full text-center backdrop-blur rounded-b-2xl"

src/components/SourceDescriptions.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {useContext, useEffect, useState} from "react";
55
import {Alias, Attribution, Coverage, Identifiers, Notes, SourceReferences} from "./GedcomXComponents";
66
import {
77
Article,
8-
ExternalContent,
98
Hr,
109
Media,
1110
ReactLink,

0 commit comments

Comments
 (0)