Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mahmoud-Checklist #9

Open
9 of 13 tasks
krakla opened this issue Oct 6, 2021 · 0 comments · Fixed by #8
Open
9 of 13 tasks

Mahmoud-Checklist #9

krakla opened this issue Oct 6, 2021 · 0 comments · Fixed by #8
Assignees
@Darin-Hamouda @Nefn-Lakhouj @omerjava
Labels
To review

Comments

@krakla
Copy link
Collaborator

krakla commented Oct 6, 2021

  • Setup: GitHub
    • created this issue
    • assigned myself
    • moved the issue to the project board
  • Setup: local
    • pulled the most recent code from main/master
    • created a new branch for my introduction
  • Writing the content:
    • added my intro file in /people according to group conventions
    • linked to my file from /README.md according to group conventions
  • Before pushing my branch:
    • formatted the code
    • fixed all spelling mistakes and added new words to the dictionary
    • fixed all linting mistakes
  • After pushing my branch:
    • created a new PR linked to this issue
    • make sure all of the checks passed
    • assigned someone to review and merge my PR
@krakla krakla linked a pull request Oct 6, 2021 that will close this issue
Abu #8
Merged
@krakla krakla closed this as completed in #8 Oct 6, 2021
@krakla krakla linked a pull request Oct 6, 2021 that will close this issue
Update README.md #10
Closed
@krakla krakla reopened this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Darin-Hamouda Darin-Hamouda

@Nefn-Lakhouj Nefn-Lakhouj

@omerjava omerjava

Labels
To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abu lab-antwerp-1/group1-Introduction
Update README.md lab-antwerp-1/group1-Introduction
4 participants
@krakla @Darin-Hamouda @Nefn-Lakhouj @omerjava