-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FR-503): open kernel log modal in Kernel list #3100
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
62611f7
to
2973165
Compare
2973165
to
3d5a36a
Compare
d3e99ec
to
7dd3436
Compare
7dd3436
to
d8f56dd
Compare
3d5a36a
to
c3e51b8
Compare
d8f56dd
to
9484af5
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 4.68% (-0% 🔻) |
400/8545 |
🔴 | Branches | 4.05% (-0% 🔻) |
239/5895 |
🔴 | Functions | 2.84% (-0% 🔻) |
78/2749 |
🔴 | Lines | 4.6% (-0% 🔻) |
385/8362 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 52c76bd
9484af5
to
46bc671
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
resolves #3138 (FR-503) Added a container log viewer button to the connected kernel list. Users can now directly view container logs for each kernel by clicking the log icon next to the kernel ID, which opens a modal displaying the container logs. ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/8ed2137c-59ab-4d84-baeb-80f2ecf44f28.png)
46bc671
to
52c76bd
Compare
resolves #3138 (FR-503)
Added a container log viewer button to the connected kernel list. Users can now directly view container logs for each kernel by clicking the log icon next to the kernel ID, which opens a modal displaying the container logs.