Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FR-503): open kernel log modal in Kernel list #3100

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Feb 5, 2025

resolves #3138 (FR-503)

Added a container log viewer button to the connected kernel list. Users can now directly view container logs for each kernel by clicking the log icon next to the kernel ID, which opens a modal displaying the container logs.

image.png

Copy link
Member Author

yomybaby commented Feb 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 force-pushed the fix/session-detail-panel-version-compatibility branch 6 times, most recently from 62611f7 to 2973165 Compare February 6, 2025 07:42
@yomybaby yomybaby force-pushed the fix/session-detail-panel-version-compatibility branch from 2973165 to 3d5a36a Compare February 7, 2025 03:19
@yomybaby yomybaby force-pushed the feat/open-kernel-log-in-kernel-list branch from d3e99ec to 7dd3436 Compare February 7, 2025 03:19
@yomybaby yomybaby changed the base branch from fix/session-detail-panel-version-compatibility to graphite-base/3100 February 7, 2025 03:22
@yomybaby yomybaby force-pushed the feat/open-kernel-log-in-kernel-list branch from 7dd3436 to d8f56dd Compare February 7, 2025 03:24
@yomybaby yomybaby changed the base branch from graphite-base/3100 to main February 7, 2025 03:25
@yomybaby yomybaby force-pushed the feat/open-kernel-log-in-kernel-list branch from d8f56dd to 9484af5 Compare February 7, 2025 03:25
Copy link

github-actions bot commented Feb 7, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
4.68% (-0% 🔻)
400/8545
🔴 Branches
4.05% (-0% 🔻)
239/5895
🔴 Functions
2.84% (-0% 🔻)
78/2749
🔴 Lines
4.6% (-0% 🔻)
385/8362

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 52c76bd

@yomybaby yomybaby force-pushed the feat/open-kernel-log-in-kernel-list branch from 9484af5 to 46bc671 Compare February 11, 2025 09:43
@yomybaby yomybaby marked this pull request as ready for review February 11, 2025 10:02
@yomybaby yomybaby requested a review from nowgnuesLee February 11, 2025 10:02
@yomybaby yomybaby changed the title feat: open kernel log modal in Kernel list feat(FR-503): open kernel log modal in Kernel list Feb 11, 2025
Copy link
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Feb 14, 2025

Merge activity

resolves #3138 (FR-503)

Added a container log viewer button to the connected kernel list. Users can now directly view container logs for each kernel by clicking the log icon next to the kernel ID, which opens a modal displaying the container logs.

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/XqC2uNFuj0wg8I60sMUh/8ed2137c-59ab-4d84-baeb-80f2ecf44f28.png)
@graphite-app graphite-app bot force-pushed the feat/open-kernel-log-in-kernel-list branch from 46bc671 to 52c76bd Compare February 14, 2025 02:52
@graphite-app graphite-app bot merged commit 52c76bd into main Feb 14, 2025
7 checks passed
@graphite-app graphite-app bot deleted the feat/open-kernel-log-in-kernel-list branch February 14, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User want to open kernel log modal for specific kernel in Kernel list
2 participants