Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pretty_assertions in intergration tests #160

Open
jopemachine opened this issue Oct 13, 2024 · 3 comments
Open

Use pretty_assertions in intergration tests #160

jopemachine opened this issue Oct 13, 2024 · 3 comments
Labels
good first issue Good for newcomers integration-test refactoring Rewrite something in better way while keeping the same functionality

Comments

@jopemachine
Copy link
Member

Ref: https://github.com/rust-pretty-assertions/rust-pretty-assertions
@jopemachine jopemachine added refactoring Rewrite something in better way while keeping the same functionality test good first issue Good for newcomers labels Oct 13, 2024
@Devansh-Negi3839
Copy link

@jopemachine
Could you please assign this to me?
Also, according to my understanding, changes have to be made only in the harness/tests.

@jopemachine
Copy link
Member Author

jopemachine commented Oct 13, 2024 •
edited
Loading

Sure, feel free to create a PR!

Also, according to my understanding, changes have to be made only in the harness/tests.

Yes, the integration tests refer to the tests under the harness directory.

@Devansh-Negi3839
Copy link

@jopemachine
Please check this PR.
#163

@jopemachine jopemachine mentioned this issue Oct 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers integration-test refactoring Rewrite something in better way while keeping the same functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Introduce pretty_assertions to integration tests Devansh-Negi3839/raftify
2 participants
@jopemachine @Devansh-Negi3839