Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Translation #257

Open
pengchzn opened this issue Jun 17, 2024 · 4 comments
Open

Chinese Translation #257

pengchzn opened this issue Jun 17, 2024 · 4 comments

Comments

@pengchzn
Copy link
Contributor

I noticed that the Chinese translation appears to be machine-generated. Do you have any plans to officially translate this excellent project? If needed, I am willing to take on the responsibility for the Chinese translation!

@vpj
Copy link
Member

vpj commented Jun 19, 2024

Yeah it's machine generated. We cannot translate because we don't know Chinese unfortunately. It's something that'll be quite useful since most of the readers are Chinese speaking.

The translations are in the folder https://github.com/labmlai/annotated_deep_learning_paper_implementations/tree/master/translate_cache

These are then used to generate the HTML

@pengchzn
Copy link
Contributor Author

Got it. So I just need to modify the translations in the translate_cache folder, right? Also, when submitting a PR, should I do it chapter by chapter or wait until the entire translation is finished and submit it all at once?

I am very grateful for the effort everyone has put into this project. It has given me a thorough understanding of neural networks. I hope to contribute to making it better.

@vpj
Copy link
Member

vpj commented Jun 20, 2024

Lets do PRs and merge them as you translate. It'll be a lot faster and you'll be able to see how the translations appear on nn.labml.ai. May be others will also join you to help.

@vpj
Copy link
Member

vpj commented Jun 20, 2024

Lets first do on one of the simplest files and test.

@vpj vpj closed this as completed Jun 21, 2024
@vpj vpj reopened this Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants