From aaed81c388695c4cf57ccc38bd4acf782fdd5fe1 Mon Sep 17 00:00:00 2001 From: Sean Mullen Date: Sun, 9 Feb 2025 16:26:32 -0800 Subject: [PATCH 1/6] define cf_undefined at the top level (defined in .lib) --- src/pylsl/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pylsl/__init__.py b/src/pylsl/__init__.py index 6de048b..5e016aa 100644 --- a/src/pylsl/__init__.py +++ b/src/pylsl/__init__.py @@ -41,3 +41,4 @@ from .lib import cf_float32 as cf_float32 from .lib import cf_double64 as cf_double64 from .lib import cf_string as cf_string +from .lib import cf_undefined as cf_undefined From 8f854576052b647282a2a43ea66575c65365bf03 Mon Sep 17 00:00:00 2001 From: Chadwick Boulay Date: Sun, 9 Feb 2025 20:26:36 -0500 Subject: [PATCH 2/6] Update ruff GHA --- .github/workflows/ci.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9148108..7caa838 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,10 +19,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: astral-sh/ruff-action@v1 - - uses: astral-sh/ruff-action@v1 - with: - args: "format --check" + - uses: astral-sh/ruff-action@v3 + - run: ruff check --output-format=github src + - run: ruff format --check src test: needs: style From 9c5797f24b8b1d3eec0ec16967c2baa25ed0a4d1 Mon Sep 17 00:00:00 2001 From: Chadwick Boulay Date: Sun, 9 Feb 2025 20:48:37 -0500 Subject: [PATCH 3/6] ruff format verbose --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7caa838..7bbf791 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,7 @@ jobs: - uses: actions/checkout@v4 - uses: astral-sh/ruff-action@v3 - run: ruff check --output-format=github src - - run: ruff format --check src + - run: ruff format --verbose --check src test: needs: style From b4cb8a93c072c348ec39baf9e77143ec47c7f1ea Mon Sep 17 00:00:00 2001 From: Chadwick Boulay Date: Sun, 9 Feb 2025 20:54:59 -0500 Subject: [PATCH 4/6] ruff CI try specifying version --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7bbf791..33c3c3c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,8 +20,11 @@ jobs: steps: - uses: actions/checkout@v4 - uses: astral-sh/ruff-action@v3 + with: + version: "0.8.2" - run: ruff check --output-format=github src - - run: ruff format --verbose --check src + - run: ruff format --check src + test: needs: style From 0ac31f82b22ba6fa564cc752b55cff9fd384e39a Mon Sep 17 00:00:00 2001 From: Chadwick Boulay Date: Sun, 9 Feb 2025 21:03:08 -0500 Subject: [PATCH 5/6] Debugging GHA problem --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 33c3c3c..4be3772 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -49,6 +49,7 @@ jobs: if: startsWith(matrix.os, 'ubuntu-') run: | sudo apt install -y libpugixml-dev + echo $(lsb_release -sc) curl -L ${LSL_RELEASE_URL}/liblsl-${LSL_RELEASE}-$(lsb_release -sc)_amd64.deb -o liblsl.deb sudo apt install ./liblsl.deb - name: Install uv From bf52e4412eaf2d2de15411026b4238b159f0caf1 Mon Sep 17 00:00:00 2001 From: Chadwick Boulay Date: Sun, 9 Feb 2025 21:18:30 -0500 Subject: [PATCH 6/6] GHA set Ubuntu to 20.04 because liblsl doesn't have a binary release for noble. --- .github/workflows/ci.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4be3772..cc03c6c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: style: name: Check style - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - uses: actions/checkout@v4 - uses: astral-sh/ruff-action@v3 @@ -31,7 +31,7 @@ jobs: strategy: matrix: python-version: ["3.9", "3.10", "3.11", "3.12"] - os: ["ubuntu-latest", "windows-latest", "macOS-latest"] + os: ["ubuntu-20.04", "windows-latest", "macOS-latest"] name: Run tests (${{ matrix.os }} Python ${{ matrix.python-version }}) runs-on: ${{ matrix.os }} @@ -49,7 +49,6 @@ jobs: if: startsWith(matrix.os, 'ubuntu-') run: | sudo apt install -y libpugixml-dev - echo $(lsb_release -sc) curl -L ${LSL_RELEASE_URL}/liblsl-${LSL_RELEASE}-$(lsb_release -sc)_amd64.deb -o liblsl.deb sudo apt install ./liblsl.deb - name: Install uv