Skip to content

Stripe fixes #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

Stripe fixes #3226

merged 1 commit into from
Feb 10, 2025

Conversation

sadhasivam-ladybirdweb
Copy link
Contributor

@sadhasivam-ladybirdweb sadhasivam-ladybirdweb commented Jan 24, 2025 •
edited
Loading

Fixes

Issues Fixed

  1. Fixed the payment decline issue in Stripe payments.
  2. Fixed the issue where users were not being added to Pipedrive after registration.
  3. Updated the intl-input package to resolve mobile input issues.
  4. Fixed the issue where the logo was not displayed for payment gateways.
  5. Fixed the issue where the logo was not displayed when generating PDF invoices.
  6. Changed the default logo in system settings.
  7. Fixed UI issues on the admin settings page.
  8. Updated the UI for logo updates.
  9. Updated front-end validation for the registration, login, contact us, 2FA, password reset, client profile update, and request demo popup forms.
  10. Updated the login system to allow users to log in using their username.

Commands to Run

php artisan migrate

@sadhasivam-ladybirdweb sadhasivam-ladybirdweb added the PD: Demo approval required Developer has to give a demo to the Product team after dev completion and only then raise PR label Jan 24, 2025
@pull-request-size pull-request-size bot added the size/XXL Issue will take a month to complete label Jan 24, 2025
@bhanu2217 bhanu2217 added PD: Demo Approved 👍 Demo of the feature / bug fix was approved by Product team and removed PD: Demo approval required Developer has to give a demo to the Product team after dev completion and only then raise PR labels Jan 24, 2025
@bhanu2217 bhanu2217 added this to the v4.0.2.3 milestone Jan 24, 2025
This was linked to issues Jan 24, 2025
Payment Declined Due to Unsafe Handling of Credit Card Data #3216
Closed
User Not Added to Pipedrive After Registration #3222
Closed
This was linked to issues Jan 24, 2025
Below all issues we have to fix in laravel update pr #3208
Closed
Requirement: Prevent Alphabetical Characters in Phone Number Field #3199
Closed
@AbishekChinnaraju
Copy link

@sadhasivam-ladybirdweb please get code approval ASAP, need to start testing

@AbishekChinnaraju AbishekChinnaraju self-assigned this Jan 24, 2025
@AbishekChinnaraju AbishekChinnaraju self-requested a review January 24, 2025 06:21
@indira15v indira15v self-requested a review January 24, 2025 06:23
@indira15v indira15v self-assigned this Jan 24, 2025
Sakthi002
Sakthi002 previously approved these changes Jan 24, 2025
View reviewed changes
@sandesh556 sandesh556 changed the title Strip fixes Stripe fixes Jan 24, 2025
sandesh556
sandesh556 previously approved these changes Jan 24, 2025
View reviewed changes
@AbishekChinnaraju AbishekChinnaraju added the QA: Round 1 Testing In Progress First round of testing is in progress label Jan 24, 2025
RafficMohammed
RafficMohammed previously approved these changes Jan 24, 2025
View reviewed changes
@indira15v indira15v added the QA: Round 2 Testing In Progress Second round of testing in progress label Jan 24, 2025
@indira15v
Copy link

Round two testing summary
Tested this PR in local instance with existing DB and checked stripe payments with 3D,non 3D ,expiration mail and renewal ,pipedrive registration(need to check)and UI related things
Note
Testing not completed
Issue sheet
https://docs.google.com/spreadsheets/d/1C47dsrUuPOqjpO14Kkb8v-7Lwme5MphPuYL7TPwoQ9U/edit?gid=0#gid=0

@AbishekChinnaraju
Copy link

AbishekChinnaraju commented Jan 27, 2025 •
edited
Loading

Round two testing summary:
I tested this PR on my local instance.
Total testing time: 1 day
Total no. issues along with query: 56
Issues from my end along with query: 31
Issue sheet
https://docs.google.com/spreadsheets/d/1C47dsrUuPOqjpO14Kkb8v-7Lwme5MphPuYL7TPwoQ9U/edit?gid=0#gid=0
Note

  • Tested this PR in a local instance with existing DB and checked stripe payments with 3D, non 3D and renewal,pipedrive registration and, UI related things.
  • Additionally, I tested Client panel UI and validation messages like in Register, Login, Register, trial, Demo, Download, Forget password pages.

@indira15v
Copy link

indira15v commented Feb 7, 2025 •
edited
Loading

Round two retesting summary
The admin panel ,cloud hub related and razorpay issues are there not fixed
Some of few fixed issues are also not working as expected
Issue sheet
https://docs.google.com/spreadsheets/d/1C47dsrUuPOqjpO14Kkb8v-7Lwme5MphPuYL7TPwoQ9U/edit?gid=0#gid=0

@sadhasivam-ladybirdweb
Copy link
Contributor Author

Round two retesting summary The admin panel ,cloud hub related and razorpay issues are there not fixed Some of few fixed issues are also not working as expected Issue sheet https://docs.google.com/spreadsheets/d/1C47dsrUuPOqjpO14Kkb8v-7Lwme5MphPuYL7TPwoQ9U/edit?gid=0#gid=0

I didn't fix any admin panel issues. The issues mentioned above are from the admin panel. For other issues that are not working as expected, please open a new sheet and add them there. I will fix them now.

@AbishekChinnaraju
Copy link

Round two retesting summary The admin panel ,cloud hub related and razorpay issues are there not fixed Some of few fixed issues are also not working as expected Issue sheet https://docs.google.com/spreadsheets/d/1C47dsrUuPOqjpO14Kkb8v-7Lwme5MphPuYL7TPwoQ9U/edit?gid=0#gid=0

I didn't fix any admin panel issues. The issues mentioned above are from the admin panel. For other issues that are not working as expected, please open a new sheet and add them there. I will fix them now.

Issue sheet: https://docs.google.com/spreadsheets/d/1C47dsrUuPOqjpO14Kkb8v-7Lwme5MphPuYL7TPwoQ9U/edit?gid=1474510#gid=1474510

Note:

  • I have mentioned my unfixed issues on third round sheet

@indira15v
Copy link

@sadhasivam-ladybirdweb Mentioned the unfixed issues in third round sheet

@sadhasivam-ladybirdweb
Copy link
Contributor Author

@sadhasivam-ladybirdweb Mentioned the unfixed issues in third round sheet

Still why few admin panel issues are added here?

@sadhasivam-ladybirdweb
Copy link
Contributor Author

Fixed Mailchimp validation and removed username login, other I have commanded please recheck once

@faveobot faveobot closed this Feb 8, 2025
@AbishekChinnaraju
Copy link

AbishekChinnaraju commented Feb 10, 2025 •
edited
Loading

Retesting Summary:
I tested this PR on my existing and fresh local instance.
Issue sheet: https://docs.google.com/spreadsheets/d/1C47dsrUuPOqjpO14Kkb8v-7Lwme5MphPuYL7TPwoQ9U/edit?gid=1474510#gid=1474510
Note:

  • The linked issue in the PR regarding Stripe only has been fixed, along with a few validation issues in the client panel.
  • Some of the mentioned issues in the sheet are not fixed. The developer has commented on the sheet regarding those.
  • I approved this PR after discussing it with my teammates.
  • The razorpay function is not working, the developer commented on the sheet for that.

@indira15v
Copy link

indira15v commented Feb 10, 2025 •
edited
Loading

Round two retesting summary
Tested this PR in local with existing DB and server with fresh installation
The client panel mentioned issues are fixed and working fine
Issue sheet
https://docs.google.com/spreadsheets/d/1C47dsrUuPOqjpO14Kkb8v-7Lwme5MphPuYL7TPwoQ9U/edit?gid=1126879400#gid=1126879400
Note
The admin panel,cloud hub issues and razorpay related things will get fixed in upcoming PR as discussed with developer

@indira15v indira15v added QA: Round 2 Testing Approved Second round of testing complete and all issues raised are fixed and removed QA: Round 2 Testing In Progress Second round of testing in progress labels Feb 10, 2025
@AbishekChinnaraju AbishekChinnaraju added QA: Round 1 Testing Approved First round of testing complete and all issues raised are fixed and removed QA: Round 1 Testing In Progress First round of testing is in progress labels Feb 10, 2025
@indira15v indira15v added QA: Functionality Approved Functionality tested and approved by QA team and removed Requires Functionality Review 🙏 QA: Round 1 Testing Approved First round of testing complete and all issues raised are fixed QA: Round 2 Testing Approved Second round of testing complete and all issues raised are fixed labels Feb 10, 2025
@sadhasivam-ladybirdweb sadhasivam-ladybirdweb linked an issue Feb 10, 2025 that may be closed by this pull request
Read me file update #3236
Closed
@sadhasivam-ladybirdweb
fix stripe payment
0642a0c 
Apply fixes from StyleCI

fix logos

Apply fixes from StyleCI

update intl input

Apply fixes from StyleCI

fix system settings

Apply fixes from StyleCI

fix test cases

fc-1 fixed

fix stripe changes

Apply fixes from StyleCI

fix existing issues

Apply fixes from StyleCI

fix bugs

Apply fixes from StyleCI

fix more bugs in client panel

Apply fixes from StyleCI

fix testcases

Apply fixes from StyleCI

fix 2fa ui changes

update readme

minor fixes

Apply fixes from StyleCI

fix mailchimp validation
@sandesh556 sandesh556 merged commit 4bfafb5 into development Feb 10, 2025
4 of 5 checks passed
@sadhasivam-ladybirdweb sadhasivam-ladybirdweb mentioned this pull request Feb 12, 2025
Closed
@sadhasivam-ladybirdweb sadhasivam-ladybirdweb mentioned this pull request Mar 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbishekChinnaraju AbishekChinnaraju AbishekChinnaraju approved these changes

@indira15v indira15v indira15v approved these changes

@Sakthi002 Sakthi002 Sakthi002 left review comments

@RafficMohammed RafficMohammed Awaiting requested review from RafficMohammed

@sandesh556 sandesh556 Awaiting requested review from sandesh556

Assignees

@AbishekChinnaraju AbishekChinnaraju

@indira15v indira15v

@sadhasivam-ladybirdweb sadhasivam-ladybirdweb

Labels
Code Approved 😻 Approved by reviewer for code quality PD: Demo Approved 👍 Demo of the feature / bug fix was approved by Product team QA: Functionality Approved Functionality tested and approved by QA team size/XXL Issue will take a month to complete
Projects
None yet
Milestone
v4.0.2.3
8 participants
@sadhasivam-ladybirdweb @AbishekChinnaraju @indira15v @bhanu2217 @Sakthi002 @sandesh556 @RafficMohammed @faveobot