Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter order in recipe components is wrong #8

Open
H-Tsubota opened this issue Feb 19, 2020 · 0 comments
Open

Parameter order in recipe components is wrong #8

H-Tsubota opened this issue Feb 19, 2020 · 0 comments

Comments

@H-Tsubota
Copy link

I use butterfly (ver 0.0.05 (JAN_12_2019)) on Rhinoceros6 Grasshopper. And I found that constructor's parameter order in recipe component may be wrong.

SteadyIncompressible and HeatTransfer is created in recipe component (UserObject) as following.

In "Butterfly_Steady Incompressible Recipe" component :

recipe = SteadyIncompressible(_turbulence_prop_, fv_schemes_, fv_solution_,
                              residual_control_, _relaxation_factors_)

In "Butterfly_Heat Transfer Recipe" component :

recipe = HeatTransfer(_turbulence_prop_, fv_schemes_, fv_solution_, residual_control_,
                      _relaxation_factors_, TRef=_temperature_)

But each class constructor are defined in "butterfly\recipe.py" as following.

class SteadyIncompressible(_SingleCommandRecipe):
    ...
    def __init__(self, turbulenceProperties=None, fvSolution=None,
                 fvSchemes=None, residualControl=None, relaxationFactors=None):
class HeatTransfer(_SingleCommandRecipe):
    ...
    def __init__(self, turbulenceProperties=None, fvSolution=None,
                 fvSchemes=None, residualControl=None, relaxationFactors=None,
                 TRef=None):

So I believe that fv_schemes_ and fv_solution_ must be reversed in recipe component .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant