Commit de60642
committed
fix(metrics): widen lean_block_building_time_seconds buckets past 1s
The leanMetrics bucket set for this histogram tops out at 1s, but block
builds on our devnets routinely take 2-3s. Every sample therefore landed
in `+Inf`, and `histogram_quantile` had no finite bucket left to
interpolate in, so it returned the upper bound of the last finite bucket.
The panel read as a flat 1s line regardless of how long builds actually
took.
Buckets now span 0.1s to 8s, the same range as
`lean_block_proposal_attestation_build_phase_seconds`, whose phases this
metric encloses. The tradeoff is sub-100ms resolution: attestation-free
blocks skip the prover and build in single-digit milliseconds, and those
now all collapse into the first bucket. The phase histogram still resolves
that end, and it is not the range we need to watch.
This deviates from the leanMetrics spec, so both the histogram and
docs/metrics.md carry a note explaining why, to keep it from being
"corrected" back to a set that cannot measure the thing.
Divergent buckets do not affect other clients: Prometheus stores each
bucket as its own series, and every boundary that was shared before
(0.1 through 1) is still present. The leanMetrics dashboard panel for this
metric queries per-instance rather than `sum by (le)` across clients, so
each histogram stays internally consistent.1 parent f022277 commit de60642
2 files changed
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
460 | 460 | | |
461 | 461 | | |
462 | 462 | | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
463 | 466 | | |
464 | 467 | | |
465 | 468 | | |
466 | 469 | | |
467 | 470 | | |
468 | | - | |
| 471 | + | |
469 | 472 | | |
470 | 473 | | |
471 | 474 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
48 | 54 | | |
49 | 55 | | |
50 | 56 | | |
| |||
0 commit comments