Run lints and tests in CI for starknet-rs-py (#224)

* Add `--all` flag to Makefile targets

* Fix compile errors

* Add test-py job to CI

* Add make deps step to jobs

* Move and rename .cargo/config.toml

* Change python3.9 -> python3

* Add compile dep to clippy target

Author: MegaRedHand

.cargo/config.toml

@@ -0,0 +1,6 @@
+# needed for mac https://pyo3.rs/v0.14.2/building_and_distribution.html#macos
+[target.x86_64-apple-darwin]
+rustflags = ["-C", "link-arg=-undefined", "-C", "link-arg=dynamic_lookup"]
+
+[target.aarch64-apple-darwin]
+rustflags = ["-C", "link-arg=-undefined", "-C", "link-arg=dynamic_lookup"]

.github/workflows/rust-tests.yml

@@ -25,10 +25,10 @@ jobs:
         cache-on-failure: true
     - name: Checkout
       uses: actions/checkout@v3
-    - name: Build
-      run: make build
     - name: Deps
       run: make deps
+    - name: Build
+      run: make build
 
   format:
     runs-on: ubuntu-20.04
@@ -44,6 +44,8 @@ jobs:
         cache-on-failure: true
     - name: Checkout
       uses: actions/checkout@v3
+    - name: Deps
+      run: make deps
     - name: Format
       run: cargo fmt --all -- --check
     - name: Run clippy
@@ -67,6 +69,25 @@ jobs:
       run: make deps
     - name: Run tests
       run: make test
+  
+  test-py:
+    runs-on: ubuntu-20.04
+    steps:
+    - name: Install Rust
+      uses: actions-rs/toolchain@v1
+      with:
+          toolchain: ${{ env.RUST_TOOLCHAIN }}
+          override: true
+          components: rustfmt, clippy
+    - uses: Swatinem/rust-cache@v2
+      with:
+        cache-on-failure: true
+    - name: Checkout
+      uses: actions/checkout@v3
+    - name: Deps
+      run: make deps
+    - name: Run rs-py tests
+      run: make test-py
 
   coverage:
     runs-on: ubuntu-20.04

Makefile

@@ -43,11 +43,11 @@ starknet_programs/%.json: starknet_programs/%.cairo
 # Normal rules.
 #
 
-build:
-	cargo build --release
+build: compile-cairo compile-starknet
+	cargo build --release --all
 
-check:
-	cargo check
+check: compile-cairo compile-starknet
+	cargo check --all
 
 deps:
 	cargo install cargo-tarpaulin --version 0.23.1
@@ -62,13 +62,13 @@ clean:
 	-rm -f starknet_programs/*.json
 	-rm -f tests/*.json
 
-clippy:
-	cargo clippy --all-targets -- -D warnings
+clippy: compile-cairo compile-starknet
+	cargo clippy --all --all-targets -- -D warnings
 
 test: compile-cairo compile-starknet
 	cargo test
 
-py-test: compile-cairo compile-starknet
+test-py: compile-cairo compile-starknet
 	. starknet-venv/bin/activate
 	cargo test -p starknet-rs-py --no-default-features --features embedded-python
 

crates/starknet-rs-py/.cargo/config

@@ -18,11 +18,11 @@ use starknet_rs::{
     business_logic::state::cached_state::UNINITIALIZED_CLASS_HASH,
     definitions::constants::{
         DEFAULT_CONTRACT_STORAGE_COMMITMENT_TREE_HEIGHT, DEFAULT_GAS_PRICE,
-        DEFAULT_SEQUENCER_ADDRESS, DEFAULT_VALIDATE_MAX_N_STEPS, N_STEPS_FEE_WEIGHT,
-        TRANSACTION_VERSION,
+        DEFAULT_SEQUENCER_ADDRESS, DEFAULT_VALIDATE_MAX_N_STEPS, TRANSACTION_VERSION,
     },
     services::api::contract_class::ContractClass,
 };
+use std::ops::Shl;
 use types::general_config::{PyStarknetChainId, PyStarknetGeneralConfig, PyStarknetOsConfig};
 
 // TODO: remove once https://github.com/lambdaclass/cairo-rs/pull/917 is merged
@@ -224,13 +224,14 @@ pub fn starknet_rs_py(_py: Python, m: &PyModule) -> PyResult<()> {
 
     m.add(
         "FAULTY_CLASS_HASH",
-        felt_str!("0x1A7820094FEAF82D53F53F214B81292D717E7BB9A92BB2488092CD306F3993F").to_biguint(),
+        felt_str!("748273551117330086452242911863358006088276559700222288674638023319407008063")
+            .to_biguint(),
     )?;
 
     m.add("UNINITIALIZED_CLASS_HASH", *UNINITIALIZED_CLASS_HASH)?;
 
     // Indentation for transactions meant to query and not addressed to the OS.
-    let query_version_base: Felt = Felt::from(1 << 128);
+    let query_version_base = Felt::from(1).shl(128u32); // == 2 ** 128
     let query_version = query_version_base + Felt::from(TRANSACTION_VERSION);
     m.add("QUERY_VERSION", query_version.to_biguint())?;