Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit codes are being reused #300

Open
2 of 3 tasks
plexus opened this issue Jul 26, 2022 · 2 comments
Open
2 of 3 tasks

Exit codes are being reused #300

plexus opened this issue Jul 26, 2022 · 2 comments
Assignees
Labels
improvement Incremental improvement of an existing feature

Comments

@plexus
Copy link
Member

plexus commented Jul 26, 2022

We have two places where we throw an early-exit with exit code 252. We should never do this, an exit code should unambiguously at the code that caused it.

  • check if we have any other duplicates
  • make sure they are all unique
  • update the docs
@alysbrooks
Copy link
Member

Looks like there's duplicates of 254, too.

Here's what I found with a quick-and-dirty ripgrep search:

src/kaocha/api.clj:84:     (throw+ {:kaocha/early-exit 254}))))
src/kaocha/plugin.clj:48:      (output/error-and-throw {:kaocha/early-exit 254} nil
src/kaocha/plugin.clj:56:        {:kaocha/early-exit 254} nil
src/kaocha/plugin.clj:68:        {:kaocha/early-exit 254} nil

src/kaocha/runner.clj:166:                                                             (throw+ {:kaocha/early-exit 252})))
src/kaocha/config.clj:31:         (throw+ {:kaocha/early-exit 252}))))
test/unit/kaocha/config_test.clj:60:    (is (= #:kaocha{:early-exit 252}

@alysbrooks alysbrooks added the improvement Incremental improvement of an existing feature label Jun 20, 2023
@alysbrooks
Copy link
Member

Mostly addressed in #303. Docs just need to be wrapped up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Incremental improvement of an existing feature
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants