Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do NOT set bufhidden=unload #511

Closed
wants to merge 1 commit into from
Closed

Do NOT set bufhidden=unload #511

wants to merge 1 commit into from

Conversation

lambdalisue
Copy link
Owner

@lambdalisue lambdalisue commented Oct 20, 2024 •
edited by coderabbitai bot
Loading

Let users decide whether to set hidden or not.

Close #510

Summary by CodeRabbit

  • New Features

    • Enhanced error handling and promise management in viewer functionality.
    • Improved robustness in the initialization and opening processes.

  • Bug Fixes

    • Fixed issues related to buffer visibility and unloading behavior.

These updates lead to a more reliable and user-friendly experience when interacting with the viewer.

@lambdalisue
Do NOT set bufhidden=unload
6343e73 
Let users decide whether to set `hidden` or not.

Close #510
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Oct 20, 2024 •
edited
Loading

Walkthrough

The changes in the viewer.vim file enhance the functionality of the fern#internal#viewer module by improving error handling and promise management in several key functions. Modifications include checks for buffer opening success in the open function, robust exception handling in the init function, and better path processing in the reveal function. Additionally, the buffer management settings have been adjusted. These changes aim to create a more reliable interaction with buffers and nodes.

Changes

File Path Change Summary
autoload/fern/internal/viewer.vim Updated function signatures for open, init, reveal, and several internal functions; added error handling and promise management in open, init, and reveal functions; modified buffer management settings.

Assessment against linked issues

Objective Addressed Explanation
Prevent E19 error when jumping back to fern buffer in nvim (#510) ✅

🐰 In the forest, where the ferns sway,
I fixed the bugs that led you astray.
With promises strong and errors in sight,
Now hopping through buffers feels just right!
So leap with joy, my friend, don’t delay,
The viewer's now better, hip-hip-hooray! 🌿

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 2cf57c6 and 6343e73.

📒 Files selected for processing (1)
  • autoload/fern/internal/viewer.vim (1 hunks)
🧰 Additional context used
🔇 Additional comments (1)
autoload/fern/internal/viewer.vim (1)

49-49: Approved: Removal of bufhidden=unload to resolve buffer navigation issues.

Removing bufhidden=unload allows users to configure the bufhidden option according to their preferences, addressing the navigation error described in issue #510. This change gives users flexibility and should enhance the buffer management experience.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@lambdalisue
Copy link
Owner Author

It seems something is wrong on Neovim latest. I need to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E19 when jumping back to fern buffer in nvim
1 participant
@lambdalisue