Skip to content

Commit 9a803ec

Browse files
lambdalisuelambdalisue
committed
refactor: Address CodeRabbit review feedback
- Use denops#notify() instead of denops#request() for mappings (non-blocking) - Add b:undo_ftplugin to properly clean up ftplugin settings - Fix relative time test to use fixed base date (avoid EOM/DST issues) - Update CLAUDE.md bad example to use actual non-English comments
1 parent 166a424 commit 9a803ec

File tree

5 files changed

+44
-20
lines changed

5 files changed

+44
-20
lines changed

‎CLAUDE.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ Good example (JSDoc):
4343
*/
4444
```
4545

46-
Bad example (vague comments):
46+
Bad example (non-English comments):
4747

4848
```
4949
/**
50-
* Parse blame output
51-
* @param content - Blame output
52-
* @returns Parsed result
50+
* Git blame の porcelain 出力を解析する
51+
* @param content - git blame --porcelain の出力
52+
* @returns パースされた blame 結果
5353
*/
5454
```

‎after/ftplugin/gin-blame.vim‎

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,21 @@ endif
1313
let b:did_ftplugin_gin_blame_after = 1
1414

1515
" Define Plug mappings for this buffer
16-
nnoremap <buffer> <silent> <Plug>(gin-blame-switch-commit) <Cmd>call denops#request('gin', 'blame:switch_to_commit', [])<CR>
17-
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-older) <Cmd>call denops#request('gin', 'blame:navigate_history', ['older'])<CR>
18-
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-newer) <Cmd>call denops#request('gin', 'blame:navigate_history', ['newer'])<CR>
16+
nnoremap <buffer> <silent> <Plug>(gin-blame-switch-commit) <Cmd>call denops#notify('gin', 'blame:switch_to_commit', [])<CR>
17+
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-older) <Cmd>call denops#notify('gin', 'blame:navigate_history', ['older'])<CR>
18+
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-newer) <Cmd>call denops#notify('gin', 'blame:navigate_history', ['newer'])<CR>
1919
2020
" Default mappings (can be disabled with g:gin_blame_disable_default_mappings)
2121
if !get(g:, 'gin_blame_disable_default_mappings', 0)
2222
nmap <buffer> <CR> <Plug>(gin-blame-switch-commit)
2323
nmap <buffer> <C-O> <Plug>(gin-blame-navigate-older)
2424
nmap <buffer> <C-I> <Plug>(gin-blame-navigate-newer)
2525
endif
26+
27+
" Undo ftplugin settings
28+
let b:undo_ftplugin_gin_blame_after = 'silent! nunmap <buffer> <CR> |'
29+
\ . ' silent! nunmap <buffer> <C-O> |'
30+
\ . ' silent! nunmap <buffer> <C-I> |'
31+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-switch-commit) |'
32+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-navigate-older) |'
33+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-navigate-newer)'

‎denops/gin/util/relative_time_test.ts‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,17 +89,15 @@ Deno.test("relativeTime", async (t) => {
8989
});
9090

9191
await t.step("returns months for times less than a year ago", () => {
92-
const now = new Date();
93-
const oneMonthAgo = new Date(now);
94-
oneMonthAgo.setMonth(now.getMonth() - 1);
92+
// Use a fixed base date (mid-month) to avoid EOM/DST issues
93+
const now = new Date("2024-06-15T12:00:00Z");
94+
const oneMonthAgo = new Date("2024-05-15T12:00:00Z");
9595
assertEquals(relativeTime(oneMonthAgo, now), "1 month ago");
9696

97-
const twoMonthsAgo = new Date(now);
98-
twoMonthsAgo.setMonth(now.getMonth() - 2);
97+
const twoMonthsAgo = new Date("2024-04-15T12:00:00Z");
9998
assertEquals(relativeTime(twoMonthsAgo, now), "2 months ago");
10099

101-
const elevenMonthsAgo = new Date(now);
102-
elevenMonthsAgo.setMonth(now.getMonth() - 11);
100+
const elevenMonthsAgo = new Date("2023-07-15T12:00:00Z");
103101
assertEquals(relativeTime(elevenMonthsAgo, now), "11 months ago");
104102
});
105103

‎ftplugin/gin-blame-nav.vim‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,22 @@ let b:did_ftplugin = 1
77
setlocal winfixbuf
88

99
" Define Plug mappings for this buffer
10-
nnoremap <buffer> <silent> <Plug>(gin-blame-switch-commit) <Cmd>call denops#request('gin', 'blame:switch_to_commit', [])<CR>
11-
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-older) <Cmd>call denops#request('gin', 'blame:navigate_history', ['older'])<CR>
12-
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-newer) <Cmd>call denops#request('gin', 'blame:navigate_history', ['newer'])<CR>
10+
nnoremap <buffer> <silent> <Plug>(gin-blame-switch-commit) <Cmd>call denops#notify('gin', 'blame:switch_to_commit', [])<CR>
11+
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-older) <Cmd>call denops#notify('gin', 'blame:navigate_history', ['older'])<CR>
12+
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-newer) <Cmd>call denops#notify('gin', 'blame:navigate_history', ['newer'])<CR>
1313
1414
" Default mappings (can be disabled with g:gin_blame_disable_default_mappings)
1515
if !get(g:, 'gin_blame_disable_default_mappings', 0)
1616
nmap <buffer> <CR> <Plug>(gin-blame-switch-commit)
1717
nmap <buffer> <C-O> <Plug>(gin-blame-navigate-older)
1818
nmap <buffer> <C-I> <Plug>(gin-blame-navigate-newer)
1919
endif
20+
21+
" Undo ftplugin settings
22+
let b:undo_ftplugin = 'setlocal winfixbuf< |'
23+
\ . ' silent! nunmap <buffer> <CR> |'
24+
\ . ' silent! nunmap <buffer> <C-O> |'
25+
\ . ' silent! nunmap <buffer> <C-I> |'
26+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-switch-commit) |'
27+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-navigate-older) |'
28+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-navigate-newer)'

‎ftplugin/gin-blame.vim‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,22 @@ let b:did_ftplugin = 1
77
setlocal winfixbuf
88

99
" Define Plug mappings for this buffer
10-
nnoremap <buffer> <silent> <Plug>(gin-blame-switch-commit) <Cmd>call denops#request('gin', 'blame:switch_to_commit', [])<CR>
11-
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-older) <Cmd>call denops#request('gin', 'blame:navigate_history', ['older'])<CR>
12-
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-newer) <Cmd>call denops#request('gin', 'blame:navigate_history', ['newer'])<CR>
10+
nnoremap <buffer> <silent> <Plug>(gin-blame-switch-commit) <Cmd>call denops#notify('gin', 'blame:switch_to_commit', [])<CR>
11+
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-older) <Cmd>call denops#notify('gin', 'blame:navigate_history', ['older'])<CR>
12+
nnoremap <buffer> <silent> <Plug>(gin-blame-navigate-newer) <Cmd>call denops#notify('gin', 'blame:navigate_history', ['newer'])<CR>
1313
1414
" Default mappings (can be disabled with g:gin_blame_disable_default_mappings)
1515
if !get(g:, 'gin_blame_disable_default_mappings', 0)
1616
nmap <buffer> <CR> <Plug>(gin-blame-switch-commit)
1717
nmap <buffer> <C-O> <Plug>(gin-blame-navigate-older)
1818
nmap <buffer> <C-I> <Plug>(gin-blame-navigate-newer)
1919
endif
20+
21+
" Undo ftplugin settings
22+
let b:undo_ftplugin = 'setlocal winfixbuf< |'
23+
\ . ' silent! nunmap <buffer> <CR> |'
24+
\ . ' silent! nunmap <buffer> <C-O> |'
25+
\ . ' silent! nunmap <buffer> <C-I> |'
26+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-switch-commit) |'
27+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-navigate-older) |'
28+
\ . ' silent! unmap <buffer> <Plug>(gin-blame-navigate-newer)'

0 commit comments

Comments
 (0)