aotriton max process count fix #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch aotriton to check MAX_JOBS environment variable in aotriton v2src/CMakeLists.txt and use that for limiting the amount of python processes allowed to build and compress hsaco files. This fixes the out of memory problem on cases where computer has lot of CPUs compared to amount of memory. Note that this fix only works when using Ninja. (cmake's limitation for add_custom_jobs command) MAX_JOBS environment variable and force to use ninja for building aotriton are set in binfo file. fixes: #178 Signed-off-by: Mika Laitio <[email protected]>
lamikr
force-pushed
the
wip/rocm_sdk_builder_612_bg_178
branch
from
3585ad7 to
fd60efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch aotriton to check MAX_JOBS environment variable in aotriton v2src/CMakeLists.txt and use that for limiting the amount of python processes allowed to build and compress hsaco files.
This fixes the out of memory problem on cases where computer has lot of CPUs compared to amount of memory.
Note that this fix only works when using Ninja.
(cmake's limitation for add_custom_jobs command)
MAX_JOBS environment variable and force to use ninja for building aotriton are set in binfo file.
fixes: #178