Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice to have: checking git global variable #6

Open
flip111 opened this issue May 27, 2024 · 2 comments
Open

Nice to have: checking git global variable #6

flip111 opened this issue May 27, 2024 · 2 comments

Comments

@flip111
Copy link
Contributor

flip111 commented May 27, 2024

It would be good if ./babs.sh -i refused to run when user.name and user.email is not set globally. Also it would probably be good to abort the script as soon as one of the patches fail to apply.

@lamikr
Copy link
Owner

lamikr commented May 30, 2024

I did some modifications to apply patch command. Are you able to check whether it's now cleaner?

./babs.sh -co
./babs.so -ap

I am kind of wondering should I have just have made one command to perform both actions. Or add third command which compines these. Any opinions?

@flip111
Copy link
Contributor Author

flip111 commented Jun 7, 2024

I would combine the commands the commands that are necessary to start the build. And then any further commands to do the build. As those two actions take the most amount of time. Any other commands i would leave it up to the user to call them after each other for more fine grained control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants