Missing Traits and Use when using method ClassGenerator::fromReflection(new ClassReflection($class))

[cao-minh-duc]

Feature Request

Q	A
New Feature	yes

Summary

I'm now a having some classes using "Trait" -> try using ClassGenerator but it generate all method, properties, constants of Trait instead of generate Trait.

[froschdesign]

@cao-minh-duc
Have you seen Laminas\Code\Generator\TraitGenerator:

laminas-code/src/Generator/TraitGenerator.php

Lines 16 to 26 in d5283e9

	class TraitGenerator extends ClassGenerator
	{
	const OBJECT_TYPE = 'trait';
	/**
	* Build a Code Generation Php Object from a Class Reflection
	*
	* @param ClassReflection $classReflection
	* @return TraitGenerator
	*/
	public static function fromReflection(ClassReflection $classReflection)

[cao-minh-duc]

Tks u. But i'm talking about Generate a Class contain Traits. Not Generate a Trait

[froschdesign]

@cao-minh-duc
Same directory:

laminas-code/src/Generator/TraitUsageGenerator.php

Line 27 in d5283e9

class TraitUsageGenerator extends AbstractGenerator implements TraitUsageInterface

[cao-minh-duc]

@cao-minh-duc
Same directory:

laminas-code/src/Generator/TraitUsageGenerator.php

Line 27 in d5283e9

class TraitUsageGenerator extends AbstractGenerator implements TraitUsageInterface

Yes. I see that and it also in

laminas-code/src/Generator/ClassGenerator.php

Line 97 in d5283e9

protected $traitUsageGenerator;

but it seem not work with method fromReflection

[froschdesign]

@cao-minh-duc
First: the documentation is missing for traits – this is a bug.

To understand what your goal is, some example code would be helpful here.

[cao-minh-duc]

@cao-minh-duc
First: the documentation is missing for traits – this is a bug.

To understand what your goal is, some example code would be helpful here.

-- \App\Models\User

namespace App\Models;

use Illuminate\Contracts\Auth\MustVerifyEmail;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Foundation\Auth\User as Authenticatable;
use Illuminate\Notifications\Notifiable;

class User extends Authenticatable
{
    use HasFactory, Notifiable;

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name',
        'email',
        'password',
    ];

    /**
     * The attributes that should be hidden for arrays.
     *
     * @var array
     */
    protected $hidden = [
        'password',
        'remember_token',
    ];

    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [
        'email_verified_at' => 'datetime',
    ];
}

-- Generate logic

$generator = ClassGenerator::fromReflection(
            new ClassReflection(\App\Models\User::class)
        );
        echo $generator->generate();

-- Result

namespace App\Models;

class User extends \Illuminate\Foundation\Auth\User
{

    public const CREATED_AT = 'created_at';

    public const UPDATED_AT = 'updated_at';

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name',
        'email',
        'password',
    ];

    /**
     * The attributes that should be hidden for arrays.
     *
     * @var array
     */
    protected $hidden = [
        'password',
        'remember_token',
    ];

    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [
        'email_verified_at' => 'datetime',
    ];

    /**
     * Get a new factory instance for the model.
     *
     * @param  mixed  $parameters
     * @return \Illuminate\Database\Eloquent\Factories\Factory
     */
    public static function factory(... $parameters)
    {
        $factory =
    }

    /**
     * Create a new factory instance for the model.
     *
     * @return \Illuminate\Database\Eloquent\Factories\Factory
     */
    protected static function newFactory()
    {
        //
    }

    /**
     * Get the entity's notifications.
     *
     * @return \Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function notifications()
    {
        return $this->morphMany(DatabaseNotification::class, 'notifiable')->orderBy('created_at', 'desc');
    }

    /**
     * Get the entity's read notifications.
     *
     * @return \Illuminate\Database\Query\Builder
     */
    public function readNotifications()
    {
        return $this->notifications()->read();
    }

    /**
     * Get the entity's unread notifications.
     *
     * @return \Illuminate\Database\Query\Builder
     */
    public function unreadNotifications()
    {
        return $this->notifications()->unread();
    }

    /**
     * Send the given notification.
     *
     * @param  mixed  $instance
     * @return void
     */
    public function notify($instance)
    {
        app(Dispatcher::class)->send($this, $instance);
    }

    /**
     * Send the given notification immediately.
     *
     * @param  mixed  $instance
     * @param  array|null  $channels
     * @return void
     */
    public function notifyNow($instance, ?array $channels = null)
    {
        app(Dispatcher::class)->sendNow($this, $instance, $channels);
    }

    /**
     * Get the notification routing information for the given driver.
     *
     * @param  string  $driver
     * @param  \Illuminate\Notifications\Notification|null  $notification
     * @return mixed
     */
    public function routeNotificationFor($driver, $notification = null)
    {
        if (method_exists($this, $method = 'routeNotificationFor'.Str::studly($driver))) {
            return $this->{$method}($notification);
        }

        switch ($driver) {
            case 'database':
                return $this->notifications();
            case 'mail':
                return $this->email;
        }
    }


}

-- Expect

namespace App\Models;

use Illuminate\Contracts\Auth\MustVerifyEmail;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Foundation\Auth\User as Authenticatable;
use Illuminate\Notifications\Notifiable;

class User extends Authenticatable
{
    use HasFactory, Notifiable;

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'name',
        'email',
        'password',
    ];

    /**
     * The attributes that should be hidden for arrays.
     *
     * @var array
     */
    protected $hidden = [
        'password',
        'remember_token',
    ];

    /**
     * The attributes that should be cast to native types.
     *
     * @var array
     */
    protected $casts = [
        'email_verified_at' => 'datetime',
    ];
}

[froschdesign]

@cao-minh-duc
Thanks for the example, which illustrates the problem very well. 👍