Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not start Session #97

Open
mimmi20 opened this issue Dec 10, 2024 · 3 comments · May be fixed by #98
Open

Can not start Session #97

mimmi20 opened this issue Dec 10, 2024 · 3 comments · May be fixed by #98
Labels
Bug Something isn't working
Milestone
2.22.1

Comments

@mimmi20
Copy link

mimmi20 commented Dec 10, 2024 •
edited
Loading

Bug Report

Q A
Version(s) 2.22.0

Summary

We are not able to start a Session after setting a Session ID.

Current behavior

The Session does not start

How to reproduce

$sessionId = $routeMatch->getParam('sessionId');

$sessionManager->setId($sessionId);
$sessionManager->start();

Expected behavior

The Session starts.

Possible Cause

The Change in these lines may cause this.
@mimmi20 mimmi20 added the Bug Something isn't working label Dec 10, 2024
@mimmi20 mimmi20 changed the title Can not set SessionId Can not start Session Dec 10, 2024
@froschdesign
Copy link
Member

@mimmi20
Is an exception thrown?

The Change in these lines may cause this.

Is the link correct?

@mimmi20
Copy link
Author

mimmi20 commented Dec 10, 2024 •
edited
Loading

Is an exception thrown?

No.

Is the link correct?

Yes.

image

We set a Session ID, but because of that the session will not be started.

@gsteel
Copy link
Member

gsteel commented Dec 10, 2024

This regression was introduced here:

https://github.com/laminas/laminas-session/pull/96/files#r1844718825

I shouldn't have let that go through because an 8.4 deprecation is no reason to break code running on 8.1+

If you have the time to send in a patch @mimmi20, I'll review and release quickly 👍

@gsteel gsteel added this to the 2.22.1 milestone Dec 10, 2024
@mimmi20 mimmi20 linked a pull request Dec 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
2.22.1
Development

Successfully merging a pull request may close this issue.

remove id check when checking for started session mimmi20/laminas-session
3 participants
@froschdesign @mimmi20 @gsteel