Unset parent_run in run_tree (#1591)

Author: hinthornw

python/langsmith/run_trees.py

@@ -54,7 +54,9 @@ class RunTree(ls_schemas.RunBase):
     id: UUID = Field(default_factory=uuid4)
     run_type: str = Field(default="chain")
     start_time: datetime = Field(default_factory=lambda: datetime.now(timezone.utc))
+    # Note: no longer set.
     parent_run: Optional[RunTree] = Field(default=None, exclude=True)
+    parent_dotted_order: Optional[str] = Field(default=None, exclude=True)
     child_runs: List[RunTree] = Field(
         default_factory=list,
         exclude={"__all__": {"parent_run_id"}},
@@ -101,13 +103,15 @@ def infer_defaults(cls, values: dict) -> dict:
             values["ls_client"] = values.pop("_client")
         if not values.get("ls_client"):
             values["ls_client"] = None
-        if values.get("parent_run") is not None:
-            values["parent_run_id"] = values["parent_run"].id
+        parent_run = values.pop("parent_run", None)
+        if parent_run is not None:
+            values["parent_run_id"] = parent_run.id
+            values["parent_dotted_order"] = parent_run.dotted_order
         if "id" not in values:
             values["id"] = uuid4()
         if "trace_id" not in values:
-            if "parent_run" in values:
-                values["trace_id"] = values["parent_run"].trace_id
+            if parent_run is not None:
+                values["trace_id"] = parent_run.trace_id
             else:
                 values["trace_id"] = values["id"]
         cast(dict, values.setdefault("extra", {}))
@@ -130,10 +134,9 @@ def ensure_dotted_order(cls, values: dict) -> dict:
         current_dotted_order = _create_current_dotted_order(
             values["start_time"], values["id"]
         )
-        if values["parent_run"]:
-            values["dotted_order"] = (
-                values["parent_run"].dotted_order + "." + current_dotted_order
-            )
+        parent_dotted_order = values.get("parent_dotted_order")
+        if parent_dotted_order is not None:
+            values["dotted_order"] = parent_dotted_order + "." + current_dotted_order
         else:
             values["dotted_order"] = current_dotted_order
         return values

python/pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "langsmith"
-version = "0.3.16"
+version = "0.3.17"
 description = "Client library to connect to the LangSmith LLM Tracing and Evaluation Platform."
 authors = ["LangChain <[email protected]>"]
 license = "MIT"

python/tests/integration_tests/fake_server.py

@@ -12,8 +12,7 @@
 def fake_function():
     span = get_current_run_tree()
     assert span is not None
-    parent_run = span.parent_run
-    assert parent_run is not None
+    assert span.parent_dotted_order
     assert "did-propagate" in span.tags or []
     assert span.metadata["some-cool-value"] == 42
     assert span.session_name == "distributed-tracing"
@@ -24,8 +23,7 @@ def fake_function():
 def fake_function_two(foo: str):
     span = get_current_run_tree()
     assert span is not None
-    parent_run = span.parent_run
-    assert parent_run is not None
+    assert span.parent_dotted_order
     assert "did-propagate" in (span.tags or [])
     assert span.metadata["some-cool-value"] == 42
     assert span.session_name == "distributed-tracing"
@@ -36,8 +34,7 @@ def fake_function_two(foo: str):
 def fake_function_three(foo: str):
     span = get_current_run_tree()
     assert span is not None
-    parent_run = span.parent_run
-    assert parent_run is not None
+    assert span.parent_dotted_order
     assert "did-propagate" in (span.tags or [])
     assert span.metadata["some-cool-value"] == 42
     assert span.session_name == "distributed-tracing"

python/tests/unit_tests/test_run_helpers.py

@@ -1296,8 +1296,7 @@ def my_traceable(text: str) -> str:
         assert rt
         assert rt.run_type == "retriever"
         assert rt.parent_run_id
-        assert rt.parent_run
-        assert rt.parent_run.run_type == "tool"
+        assert rt.parent_dotted_order
         assert rt.session_name == "foo"
         return my_grandchild_tool.invoke({"text": text}, {"run_id": gc_run_id})
 

python/tests/unit_tests/test_utils.py

@@ -113,7 +113,7 @@ def grandchild_function():
         assert rt
         assert rt.parent_run_id is None
         assert "." not in rt.dotted_order
-        assert rt.parent_run is None
+        assert rt.parent_dotted_order is None
         return 1
 
     @traceable